Fixed an issue where different cache key is generated for the same message content. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claygriffiths
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
LGTM pending the addition of a code comment.
@spivurno This may be something we want to do with LMTs in GPPA, but that will likely be more complex to handle.
When you Squash & Merge, your PR title is mostly fine, but make sure it ends in a full stop (period or exclamation). Here's what I'd use:
Fixed an issue where different cache keys could be generated with the same input resulting in different responses.
barthc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2560473810/64343
Summary
The issue here is the message string that is used to generate the cache key. Though both values(first the value used to populate the live merge tag, and the one used to run the feed on form submission) look the same, but
strlenshows they have different lengths.