gpasc-radio-button-toggle.js: Added snippet to toggle GPASC auto save client side using radio buttons.
#631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veryspry
force-pushed
the
matt/gpasc-radio-button-toggle
branch
2 times, most recently
from
17f32d4
to
e736e36
Compare
veryspry
force-pushed
the
matt/gpasc-radio-button-toggle
branch
from
e736e36
to
aa9d059
Compare
veryspry
changed the title
gpasc-radio-button-toggle.js: Added snippet to toggle GPASC auto save client side using radio buttons.gpasc-radio-button-toggle.js: Added snippet to toggle GPASC auto save client side using radio buttons.
veryspry
commented
Mar 2, 2023
…ve client side using radio buttons.
…if enable/disable selectors come up empty and refactored to use GFFORMID.
veryspry
force-pushed
the
matt/gpasc-radio-button-toggle
branch
from
7078ee1
to
d04c95c
Compare
|
@claygriffiths I made those suggested changes (and tested them ofc) so I'm going to go ahead and merge since (to my knowledge) haven't seen any issues with this particular snippet from the user I sent this to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2151546100/44070?folderId=6987275
Summary
Adds snippet to allow radio buttons to toggle ASC on/off.
See also the required sister code change within GPASC: https://github.com/gravitywiz/gp-advanced-save-and-continue/pull/9