gpfr-global-filename-template.php: Fixed issue where {i} merge tag would increment twice as fast as it should.
#700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spivurno
approved these changes
Aug 28, 2023
…g would increment twice as fast as it should.
veryspry
force-pushed
the
matt/gpfr-fix
branch
from
f44786a
to
17f0e0b
Compare
veryspry
changed the title
gpfr-global-filename-template.php: Fix issue where {i} merge tag would increment twice as fast as it should.gpfr-global-filename-template.php: Fixed issue where {i} merge tag would increment twice as fast as it should.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2330760345/53504?folderId=6987275
Summary
Calling
get_template_value()more than once per file can be problematic as it can cause the{i}merge tag to be incremented twice as fast as it should be.This change leverages a new filter,
gpfr_filename_template, that allows the filename template to be modified beforeget_template_value()is called internally within GPFR.🚨 Relies on the changes in this GPNF pull request: https://github.com/gravitywiz/gp-file-renamer/pull/13