gpep-map-multiple-source-fields-to-target-field.php: Added a snippet to utilize multiple source form fields mapped to a single target form field.
#705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p`: Added a snippet to utilize multiple source form fields mapped to a single target form field.
|
Good stuff, @saifsultanc! Didn't review the snippet but just wanted to suggest we shorten the name to |
claygriffiths
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
LGTM pending:
- Fix PHPCS issue
- Change name per @spivurno's suggestion
- Implement my quick suggestion as
array_pushisn't our preferred way to add to arrays
gp-easy-passthrough/gpep-multiple-source-form-fields-mapped-to-same-target-form-field.php
Outdated
Show resolved
Hide resolved
…t to utilize multiple source form fields mapped to a single target form field.
saifsultanc
changed the title
gpep-multiple-source-form-fields-mapped-to-same-target-form-field.php: Added a snippet to utilize multiple source form fields mapped to a single target form field.gpep-map-multiple-source-fields-to-target-field.php: Added a snippet to utilize multiple source form fields mapped to a single target form field.
saifsultanc
deleted the
saif/add/54177-add-multiple-source-form-fields-snippet
branch
spivurno
pushed a commit
that referenced
this pull request
Oct 7, 2023
…t to utilize multiple source form fields mapped to a single target form field. (#705)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2347765517/54177?folderId=3808239
Summary
If multiple Source Form Fields are Mapped to the same Target Form Field, use a previous mapping rule in case the current one does not have any value.
Explanation:
https://www.loom.com/share/d3ae6ba5370a44da9d6c16d36b048c5b