Fix validation error for the decimal quantity field #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arts with the decimal sign (dot/comma)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix validation error for the decimal quantity field when the value starts with the decimal sign (dot/comma).
As can be seen in the screenshot below, form validation fails for a value like
.2- which is a valid value - even when the total is correctly calculated. This is quite inconsistent.Code formatting/refactoring was also done for some parts of the existing code in order to provide clarity and reduce repetitions e.g. the
GFCommon::is_numericmethod was used 4 times in the old code but just twice in the new code.Context
⛑️ Ticket(s): https://secure.helpscout.net/link/to/conversation
📓 Notion: https://notion.so/link/to/card
💬 Slack: https://slack.com/link/to/thread-or-message
Summary