gw-random-fields.php: Fixed fields re-appearing in subsequent pages in a multi-page form.
#810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a multi-page form, when the order of fields is randomized, on subsequent pages, fields may re-appear. Also, fields that are yet to be filled at all might even be re-ordered to previous pages!
|
Dang. It's clear you've invested some time in this @lanresmith. There's an open PR that has an improved version of this snippet that accounts for some other scenarios. I'm curious if you could try that branch to see if solves this issue: Let me know if it does not and I'll go ahead and set up a project to roll this entire snippet into GP Randomizer. Given your new product knowledge, I'll let you take lead on that. 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2567849650/64749/
Summary
In a multi-page form, when the order of fields is randomized, on subsequent pages, fields may re-appear. Also, fields that are yet to be filled at all might even be re-ordered to previous pages! This PR ensures that for a multi-page form, fields are shuffled only once. This appears to be how the UX can be fixed.