-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gw-fuzzy-match.php
: Added snippet for fuzzy comparison.
#875
Conversation
@saifsultanc Haven't tested functionality but saw that this was submitted as two separate files. As a general rule, let's avoid this if we can in favor of our PHP/JS snippet template. It's so much easier for our customers to understand and install and keeps all future changes in a single file. 🙏 |
Noted. Will sort this out Monday. |
Updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, @saifsultanc!
Feedback below all to do with positioning this as a GF snippet rather than a GPCP snippet.
gpcp-fuzzy-comparison.php
: Added snippet for fuzzy comparison.gw-fuzzy-comparison.php
: Added snippet for fuzzy comparison.
gw-fuzzy-comparison.php
: Added snippet for fuzzy comparison.gw-fuzzy-match.php
: Added snippet for fuzzy comparison.
@spivurno Updated all points. Lmk what you think about this now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saifsultanc Left some minor copy edits inline. Review, merge, and we're golden. 🙌
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2684279710/70182?
Summary
Fuzzy logic comparison for "is" operator.
Demo:
https://www.loom.com/share/a00c9279ca3d4958b1d08004951beffb