gplc-gspc-compatibility.php: Added new snippet to check validation before an order is created.
#893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $items = $order->get_items(); | ||
|
|
||
| foreach ( $items as $item ) { | ||
| $gspc_order_item = new WC_Order_Item( $item ); |
There was a problem hiding this comment.
Suggested change
| $gspc_order_item = new WC_Order_Item( $item ); | |
| $gspc_order_item = new GS_Product_Configurator\WC_Order_Item( $item ); |
I think you're going to need the namespace here. Is this snippet confirmed working right now?
There was a problem hiding this comment.
@claygriffiths Yes the snippet is working.
| */ | ||
|
|
||
| add_action( 'woocommerce_checkout_create_order', function( $order ) { | ||
| if ( ! function_exists( 'gp_limit_choices' ) ) { |
There was a problem hiding this comment.
I'd also check for GSPC here
…before an order is created.
barthc
force-pushed
the
barth/add/70877-gplc-gspc-compatibility
branch
from
38e4ed8
to
60f1f4e
Compare
claygriffiths
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2696647789/70877
Summary
Added new snippet to check validation again before an order is created.