gw-progress-meter.php: Fixed an issue where refunds are included in the total paid count.
#897
Conversation
barthc
changed the title
gravity-forms/gw-progress-meter.php: Fixed an issue where refunds are included in the total paid count.
barthc
changed the title
gw-progress-meter.php: Fixed an issue where refunds are included in the total paid count.
gravity-forms/gw-progress-meter.php
Outdated
| AND e.status = 'active' | ||
| AND e.payment_status = 'Paid'\n", |
There was a problem hiding this comment.
@spivurno Should we be adding this conditional in both of these spots? Thinking out loud, what if the form doesn't have payments wired up?
As an aside, should the partial entries bit be moved outside of the else to right above $sql?
There was a problem hiding this comment.
@claygriffiths We'll only want this in the first condition that checks for the presence of the payment_amount. This entry property is only populated if a payment feed is configured (regardless of the presence of product fields on the form).
As for partial entries, I don't think it's possible for a payment to be captured on a partial entry... maybe with Gravity Flow? My gut is to not change that until we have a bug report.
There was a problem hiding this comment.
We'll only want this in the first condition that checks for the presence of the payment_amount.
Thought so but wasn't 100% sure 😄
As for partial entries, I don't think it's possible for a payment to be captured on a partial entry... maybe with Gravity Flow? My gut is to not change that until we have a bug report.
Makes sense!
… the total paid count.
barthc
force-pushed
the
barth/fix/71589-refunds
branch
from
e13d4e0
to
418b485
Compare
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2711207909/71589
Summary
When the total paid count is calculated refunds are included, this PR will the issue by excluding refunds.