gw-preserve-datepicker-date-selection-when-changing-months.js: Fixed an issue with edge cases like 29 February, 31 April etc.
#915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d an issue with edge cases like 29 February, 31 April etc.
…d an issue with edge cases like 29 February, 31 April etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2725332347/72239
Summary
Issues with edge cases. For instance, if we had the selection as 31 October and then we chose the month of April. Since it cannot select 31st April, it is going to end up selection as 1st of May (outside our month selection of April). Likewise, 30 April and then selecting February would select 2nd March (for non-leap) and 1st March (for leap year). All these edge cases have been handled with a
maxDay, so any date selection is capped to that max value.BEFORE:
https://www.loom.com/share/cdf3a97e31684d3899311a24c6aeb6f6
AFTER:
https://www.loom.com/share/45ad6bb1f061409195bbc20910846c3e