Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resolve_device instead of poll_device in order to allow use persistent block device naming in encryptssh #16

Open
carbolymer opened this issue Nov 18, 2021 · 1 comment

Comments

@carbolymer
Copy link

Currently encryptssh hook is using poll_device function to poll device with encryption key: https://github.com/grazzolini/mkinitcpio-utils/blob/master/initcpio/hooks/encryptssh#L19
It would be better to follow persistent block device naming: https://wiki.archlinux.org/title/Persistent_block_device_naming
similarly to encrypt encrypt hook:
https://github.com/archlinux/svntogit-packages/blob/packages/cryptsetup/trunk/hooks-encrypt#L16

I believe resolve_device could be just used in place of poll_device for this purpose.

@mickybart
Copy link

I'm proposing a PR #17 to fix this issue and much more.
The code has been reworked to align with the one from cryptsetup package (encrypt). That permit to use discard and disable workqueue for SSD as documented for encrypt in https://wiki.archlinux.org/title/Dm-crypt/Specialties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants