[DOCS] Expectation selection, group by data quality issue #10806
+57
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #10806 +/- ##
===========================================
- Coverage 80.69% 80.69% -0.01%
===========================================
Files 465 465
Lines 40449 40449
===========================================
- Hits 32640 32639 -1
- Misses 7809 7810 +1 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
klavavej
commented
Dec 20, 2024
| | Volume | `expect_table_row_count_to_equal_other_table` | Expect the number of rows to equal the number in another table within the same database. | No | | ||
| | Data quality issue | Expectation | Description | Dynamic Parameters? | | ||
| |------------------|----------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------|-------------------| | ||
| | Completeness | **column values to be null** | Expect the column values to be null. | Coming soon | |
There was a problem hiding this comment.
note for reviewers: Though not in the plan, I updated the Expectation names to remove "Expect" from the beginning of each one to match how these options will be presented in the UI. I also styled them in bold as references to UI options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://greatexpectations.atlassian.net/browse/DOC-1001 according to the plan linked in that issue
invoke lint(usesruff format+ruff check)For more information about contributing, visit our community resources.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!