Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] small fixes for newer DQ use case articles #10847

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

klavavej
Copy link
Contributor

@klavavej klavavej commented Jan 10, 2025

This issueless PR removes one mention of suites in the context of the GX Cloud UI as a follow up to #10665 (some newer data quality use case pages were in flight at the same time as the SUJ-E docs updates so I took a look through them to see if there was anything that should be updated to reflect SUJ-E). This PR also fixes some small typos I noticed while looking through these pages

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, visit our community resources.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit cd06671
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6788190522d6960008960033
😎 Deploy Preview https://deploy-preview-10847.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.69%. Comparing base (44b4aad) to head (cd06671).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10847   +/-   ##
========================================
  Coverage    80.69%   80.69%           
========================================
  Files          465      465           
  Lines        40493    40493           
========================================
+ Hits         32676    32677    +1     
+ Misses        7817     7816    -1     
Flag Coverage Δ
3.10 69.99% <ø> (+<0.01%) ⬆️
3.11 70.00% <ø> (ø)
3.12 70.00% <ø> (ø)
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.40% <ø> (ø)
3.12 aws_deps 46.24% <ø> (ø)
3.12 big 54.75% <ø> (ø)
3.12 bigquery 48.52% <ø> (ø)
3.12 databricks 50.29% <ø> (ø)
3.12 filesystem 62.74% <ø> (ø)
3.12 mssql 51.29% <ø> (ø)
3.12 mysql 51.70% <ø> (ø)
3.12 postgresql 54.34% <ø> (ø)
3.12 snowflake 51.11% <ø> (ø)
3.12 spark 57.68% <ø> (ø)
3.12 spark_connect 46.53% <ø> (ø)
3.12 trino 52.25% <ø> (ø)
3.9 70.01% <ø> (-0.02%) ⬇️
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.40% <ø> (ø)
3.9 aws_deps 46.26% <ø> (ø)
3.9 big 54.76% <ø> (ø)
3.9 bigquery 48.52% <ø> (ø)
3.9 clickhouse 43.15% <ø> (ø)
3.9 databricks 50.29% <ø> (ø)
3.9 filesystem 62.74% <ø> (ø)
3.9 mssql 51.27% <ø> (ø)
3.9 mysql 51.68% <ø> (ø)
3.9 postgresql 54.33% <ø> (ø)
3.9 snowflake 51.11% <ø> (ø)
3.9 spark 57.64% <ø> (ø)
3.9 spark_connect 46.54% <ø> (ø)
3.9 trino 52.23% <ø> (ø)
cloud 0.00% <ø> (ø)
docs-basic 53.90% <ø> (ø)
docs-creds-needed 52.85% <ø> (ø)
docs-spark 52.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@klavavej klavavej marked this pull request as ready for review January 13, 2025 16:06
Copy link
Contributor

@rachhouse rachhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catches! Thank you for fixing these.

@klavavej klavavej added this pull request to the merge queue Jan 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2025
@klavavej klavavej enabled auto-merge January 14, 2025 14:58
@klavavej klavavej added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2025
@klavavej klavavej added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2025
@klavavej klavavej added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2025
@klavavej klavavej added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@klavavej klavavej enabled auto-merge January 15, 2025 18:45
@klavavej klavavej added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@klavavej klavavej added this pull request to the merge queue Jan 15, 2025
@klavavej klavavej removed this pull request from the merge queue due to a manual request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants