Skip to content

Commit

Permalink
Merge pull request #178 from greatscottgadgets/revert-173-antoinevg/d…
Browse files Browse the repository at this point in the history
…oc-update

Revert "Update docs & cli to help prevent folk from trying to run Facedancer on Windows."
  • Loading branch information
antoinevg authored Aug 20, 2024
2 parents 992d2d9 + 93d8ff7 commit 4baa7c6
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 30 deletions.
10 changes: 1 addition & 9 deletions cynthion/python/src/commands/cynthion_flash.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

""" Cynthion 'flash' command. """

import logging, platform, sys
import logging

from .util import find_cynthion_asset, find_cynthion_bitstream
from .util import flash_bitstream, flash_mcu_firmware, flash_soc_firmware
Expand All @@ -23,14 +23,6 @@ def cynthion_flash(device, args):
elif args.target == "analyzer":
flash_bitstream(device, find_cynthion_bitstream(device, "analyzer.bit"))
elif args.target == "facedancer":
if platform.system() == "Windows":
logging.error("\nFacedancer and USBProxy are not currently supported on Windows.")
logging.error("Attempting to use Facedancer or USBProxy on Windows may cause")
logging.error("USB analysis to stop working.\n")
logging.error("For more information please see the tracking issue:\n")
logging.error(" https://github.com/greatscottgadgets/cynthion/issues/170\n")
logging.error("Command aborted.")
sys.exit(1)
flash_soc_firmware(device, find_cynthion_asset("moondancer.bin"))
flash_bitstream(device, find_cynthion_bitstream(device, "facedancer.bit"))
elif args.target == "selftest":
Expand Down
10 changes: 1 addition & 9 deletions cynthion/python/src/commands/cynthion_run.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

""" Cynthion 'run' command. """

import logging, os, platform, subprocess, sys, tempfile
import logging, os, subprocess, sys, tempfile

from .util import find_cynthion_asset, find_cynthion_bitstream
from .util import flash_soc_firmware, run_bitstream
Expand All @@ -21,14 +21,6 @@ def cynthion_run(device, args):
run_bitstream(device, find_cynthion_bitstream(device, f"analyzer.bit"))

elif args.target == "facedancer":
if platform.system() == "Windows":
logging.error("\nFacedancer and USBProxy are not currently supported on Windows.")
logging.error("Attempting to use Facedancer or USBProxy on Windows may cause")
logging.error("USB analysis to stop working.\n")
logging.error("For more information please see the tracking issue:\n")
logging.error(" https://github.com/greatscottgadgets/cynthion/issues/170\n")
logging.error("Command aborted.")
sys.exit(1)
flash_soc_firmware(device, find_cynthion_asset("moondancer.bin"))
run_bitstream(device, find_cynthion_bitstream(device, f"facedancer.bit"))

Expand Down
6 changes: 0 additions & 6 deletions docs/source/getting_started_facedancer.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,6 @@
Using Cynthion with Facedancer
==============================

.. warning::

Facedancer is not currently supported on Windows. Attempting to use Facedancer on Windows may cause USB analysis to stop working.

For more information please see the tracking issue: `#170 <https://github.com/greatscottgadgets/cynthion/issues/170>`__

Before proceeding, please ensure you have completed all steps in the :doc:`getting_started` section.


Expand Down
6 changes: 0 additions & 6 deletions docs/source/getting_started_usbproxy.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,6 @@
Using Cynthion with USB Proxy
=============================

.. warning::

USBProxy is not currently supported on Windows. Attempting to use USB Proxy on Windows may cause USB analysis to stop working.

For more information please see the tracking issue: `#170 <https://github.com/greatscottgadgets/cynthion/issues/170>`__

Before proceeding, please ensure you have completed all steps in the :doc:`getting_started` and :doc:`getting_started_facedancer` sections.


Expand Down

0 comments on commit 4baa7c6

Please sign in to comment.