-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
7 changed files
with
184 additions
and
67 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95 changes: 78 additions & 17 deletions
95
...ava/org/greencodeinitiative/creedengo/java/checks/NoFunctionCallWhenDeclaringForLoop.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,58 +1,119 @@ | ||
| package org.greencodeinitiative.creedengo.java.checks; | ||
|
|
||
| package org.greencodeinitiative.creedengo.java.integration.tests;/* | ||
| * creedengo - Java language - Provides rules to reduce the environmental footprint of your Java programs | ||
| * Copyright © 2024 Green Code Initiative (https://green-code-initiative.org/) | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
| import java.util.Iterator; | ||
| import java.util.List; | ||
| import java.util.ListIterator; | ||
| import java.util.Arrays; | ||
| class NoFunctionCallWhenDeclaringForLoop { | ||
| NoFunctionCallWhenDeclaringForLoop(NoFunctionCallWhenDeclaringForLoop mc) { | ||
| } | ||
|
|
||
| public int getMyValue() { | ||
| return 6; | ||
| } | ||
|
|
||
| public int incrementeMyValue(int i) { | ||
| public int incrementeMyValue(final int i) { | ||
| return i + 100; | ||
| } | ||
|
|
||
| public void test1() { | ||
| for (int i = 0; i < 20; i++) { | ||
| for (int i = 0; i < 20; ++i) { | ||
| System.out.println(i); | ||
| boolean b = getMyValue() > 6; | ||
| final boolean b = getMyValue() > 6; | ||
| System.out.println(b); | ||
| } | ||
| } | ||
|
|
||
| public void test2() { | ||
| String[] cars = {"Volvo", "BMW", "Ford", "Mazda"}; | ||
| for (String i : cars) { | ||
| final String[] cars = {"Volvo", "BMW", "Ford", "Mazda"}; | ||
| for (final String i : cars) { | ||
| System.out.println(i); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| // compliant, the function is called only once in the initialization so it's not a performance issue | ||
| public void test3() { | ||
| for (int i = getMyValue(); i < 20; i++) { // Noncompliant {{Do not call a function when declaring a for-type loop}} | ||
| for (int i = getMyValue(); i < 20; ++i) { | ||
| System.out.println(i); | ||
| boolean b = getMyValue() > 6; | ||
| final boolean b = getMyValue() > 6; | ||
| System.out.println(b); | ||
| } | ||
| } | ||
|
|
||
| public void test4() { | ||
| for (int i = 0; i < getMyValue(); i++) { // Noncompliant {{Do not call a function when declaring a for-type loop}} | ||
| for (int i = 0; i < getMyValue(); ++i) { // Noncompliant {{Do not call a function when declaring a for-type loop}} | ||
| System.out.println(i); | ||
| boolean b = getMyValue() > 6; | ||
| final boolean b = getMyValue() > 6; | ||
| System.out.println(b); | ||
| } | ||
| } | ||
|
|
||
| public void test5() { | ||
| for (int i = 0; i < getMyValue(); incrementeMyValue(i)) { // Noncompliant {{Do not call a function when declaring a for-type loop}} | ||
| for (final int i = 0; i < getMyValue(); incrementeMyValue(i)) { // Noncompliant {{Do not call a function when declaring a for-type loop}} | ||
| System.out.println(i); | ||
| boolean b = getMyValue() > 6; | ||
| final boolean b = getMyValue() > 6; | ||
| System.out.println(b); | ||
| } | ||
| } | ||
|
|
||
| public void test6() { | ||
| for (int i = getMyValue(); i < getMyValue(); i++) { // Noncompliant {{Do not call a function when declaring a for-type loop}} | ||
| for (int i = getMyValue(); i < getMyValue(); ++i) { // Noncompliant {{Do not call a function when declaring a for-type loop}} | ||
| System.out.println(i); | ||
| boolean b = getMyValue() > 6; | ||
| final boolean b = getMyValue() > 6; | ||
| System.out.println(b); | ||
| } | ||
| } | ||
|
|
||
| // compliant, iterators are allowed to be called in a for loop | ||
| public void test7() { | ||
| final List<String> joursSemaine = Arrays.asList("Lundi", "Mardi", "Mercredi", "Jeudi", "Vendredi", "Samedi", "Dimanche"); | ||
|
|
||
| String jour = null; | ||
| // iterator is allowed | ||
| for (final Iterator<String> iterator = joursSemaine.iterator(); iterator.hasNext(); jour = iterator.next()) { | ||
| System.out.println(jour); | ||
| } | ||
|
|
||
| // subclass of iterator is allowed | ||
| for (final ListIterator<String> iterator = joursSemaine.listIterator(); iterator.hasNext(); jour = iterator.next()) { | ||
| System.out.println(jour); | ||
| } | ||
|
|
||
| // iterator called in an indirect way is allowed | ||
| for (final OtherClassWithIterator otherClass = new OtherClassWithIterator(joursSemaine.iterator()); otherClass.iterator.hasNext(); jour = otherClass.iterator.next()) { | ||
| System.out.println(jour); | ||
| } | ||
| // but using a method that returns an iterator causes an issue | ||
| for (final OtherClassWithIterator otherClass = new OtherClassWithIterator(joursSemaine.iterator()); otherClass.getIterator().hasNext(); jour = otherClass.getIterator().next()) { // Noncompliant {{Do not call a function when declaring a for-type loop}} | ||
| System.out.println(jour); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| } | ||
|
|
||
| class OtherClassWithIterator { | ||
| public final Iterator<String> iterator; | ||
|
|
||
| public OtherClassWithIterator(Iterator<String> iterator){ | ||
| this.iterator = iterator; | ||
| } | ||
|
|
||
| public Iterator<String> getIterator(){ | ||
| return iterator; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 2 additions & 23 deletions
25
src/test/files/AvoidGettingSizeCollectionInForLoopBad.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.