Merge pull request #8 from green-code-initiative/ISSUE_7

[ISSUE 7] EC2 rule : correction NullPointer with interface

CHANGELOG.md

@@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- [#7](https://github.com/green-code-initiative/ecoCode-java/issues/7) EC2 rule : correction NullPointer with interface
+
 ### Deleted
 
 ## [1.5.0] - 2024-01-06

src/main/java/fr/greencodeinitiative/java/checks/AvoidMultipleIfElseStatement.java

@@ -65,6 +65,8 @@ public List<Kind> nodesToVisit() {
     public void visitNode(@SuppressWarnings("NullableProblems") Tree pTree) {
 
         MethodTree method = (MethodTree)pTree;
+        if (method.block() == null) // in an interface, there are some methods without block : thus, is to avoid NPE
+            return;
 
         // reinit data structure before each method analysis
         variablesStruct = new VariablesPerLevelDataStructure();

src/test/files/AvoidMultipleIfElseStatementInterface.java

@@ -0,0 +1,24 @@
+/*
+ * ecoCode - Java language - Provides rules to reduce the environmental footprint of your Java programs
+ * Copyright © 2023 Green Code Initiative (https://www.ecocode.io)
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+package fr.greencodeinitiative.java.checks;
+
+interface AvoidMultipleIfElseStatementCheck {
+
+    TransactionMetaData initMetaData(ITransactionFoundation transactionFoundation) throws ProgramException, MnemonicTemplateShellException;
+
+}

src/test/java/fr/greencodeinitiative/java/checks/AvoidMultipleIfElseStatementTest.java

@@ -27,6 +27,10 @@ void test() {
                 .onFile("src/test/files/AvoidMultipleIfElseStatement.java")
                 .withCheck(new AvoidMultipleIfElseStatement())
                 .verifyIssues();
+        CheckVerifier.newVerifier()
+                .onFile("src/test/files/AvoidMultipleIfElseStatementInterface.java")
+                .withCheck(new AvoidMultipleIfElseStatement())
+                .verifyNoIssues();
         CheckVerifier.newVerifier()
                 .onFile("src/test/files/AvoidMultipleIfElseStatementNoIssue.java")
                 .withCheck(new AvoidMultipleIfElseStatement())