Rename count_total_excluded -> count_excluded #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a past PR the progress calculation was adjusted and introduced a new count_total_excluded, which replaced the count_excluded field. This caused issues parsing the XML. As the name count_total was completely replaced by count_total_excluded, renaming it fixed this issue.
Kraemii
force-pushed
the
rename-excluded-count
branch
from
a97892a to
37afc49
Compare
jjnicola
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a past PR the progress calculation was adjusted and introduced a new count_total_excluded, which replaced the count_excluded field. This caused issues parsing the XML. As the name count_total was completely replaced by count_total_excluded, renaming it fixed this issue.