Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix C++17 detection for clang #202

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Fix C++17 detection for clang #202

merged 1 commit into from
Jun 28, 2023

Commits on Jun 28, 2023

  1. Fix C++17 detection for clang 

    Clang (even recent, e.g. llvm 16) sets __GNUC__ to 4, so the check for C++17 fails.

This results in the check for invoke_result_t in phmap_base.h failing, so it uses std::result_of, which is removed entirely in recent libc++, breaking the build.
    @ecatmur
    ecatmur committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    2ac0518 View commit details
    Browse the repository at this point in the history