Skip to content

Commit

Permalink
usbreset: replace some unbounded strcpy() calls
Browse files Browse the repository at this point in the history
We "know" the sysfs attribute is not going to be bigger than the buffer,
but the thousands of "ooh, a strcpy() call is bad for you!" scanning
tools do not.  So to shut them up, use strncpy() just to make things
quiet and for us to stop getting foolish reports.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
gregkh committed Oct 22, 2024
1 parent a73e7ce commit bb1e4b7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions usbreset.c
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,11 @@ static struct usbentry *parse_devlist(DIR *d)

attr = sysfs_attr(e->d_name, "manufacturer");
if (attr)
strcpy(dev.vendor_name, attr);
strncpy(dev.vendor_name, attr, sizeof(dev.vendor_name) - 1);

attr = sysfs_attr(e->d_name, "product");
if (attr)
strcpy(dev.product_name, attr);
strncpy(dev.product_name, attr, sizeof(dev.product_name) - 1);

if (dev.bus_num && dev.dev_num && dev.vendor_id >= 0 && dev.product_id >= 0)
return &dev;
Expand Down

0 comments on commit bb1e4b7

Please sign in to comment.