Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new "Long Initial" tip #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add new "Long Initial" tip #105

wants to merge 1 commit into from

Conversation

Nokel81
Copy link

@Nokel81 Nokel81 commented Apr 20, 2021

No description provided.

@Nokel81 Nokel81 mentioned this pull request Apr 20, 2021
Open
@Nokel81
Copy link
Author

Nokel81 commented Nov 1, 2023

@rpspringuel Could I please get a review on this

rpspringuel
rpspringuel reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@rpspringuel rpspringuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good tip, just needs some sprucing up to make it easier for novices to understand and use.

You'll also need to edit the tipsntricks.html file to link to this trick before this PR is complete.

tips/long-initial.html

<h1>Long Initial</h1>

<p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be useful to have a picture of what you're talking about to start the tip off. The title "Long Initial" makes sense once I understand what you're talking about, but it's not self-evident from the title alone.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, sounds good

tips/long-initial.html
This can also be used as the initial of your chant, and the entire tag will be considered the whole of the initial.
</p>
<p>
Note: all of these example must be done with the <code>initiallines</code> being <code>1</code>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get a simple full example here. Something that a user can copy-paste onto their computer and compile themselves.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@eschwab
Copy link
Contributor

eschwab commented Nov 17, 2023

Need to create a link in tipsntricks.html which points to tips/long-initial.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpspringuel rpspringuel rpspringuel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nokel81 @eschwab @rpspringuel