Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes getting newbile block when not newbie. #317

Closed
tomasbrod opened this issue May 22, 2017 · 7 comments
Closed

Sometimes getting newbile block when not newbie. #317

tomasbrod opened this issue May 22, 2017 · 7 comments

Comments

@tomasbrod
Copy link
Member

tomasbrod commented May 22, 2017

On testnet sometimes I get newbie DPoR block. This block is known by research reward of exactly 1 GRC. I traced with debugger and found that GetHistoricalMagnitude returns pointer to genesis block when the newbie is created. Its should return pointer to previous block staked by cpid.
This does not happen always.
Why important: non-deterministic behavior, potential loss of research rewards.

@iFoggz
Copy link
Member

iFoggz commented May 22, 2017

It happens on prod sometimes daily or multi-daily I've seen. I see them in my debug logs on nodes as well as local.

@tomasbrod
Copy link
Member Author

Happening now on production network for me. And since the total mint with 1grc newbie boost is not enough to pass mint limiter, the block gets rejected.

CreateCoinStake: Found Kernel;
CreateCoinStake: added kernel type=1 credit=0,010000
created coin stake
created rest of the block

 Newbie Special First Stake for CPID 46f64d69eb8c5ee9cd24178b589af83f, Age 19,147662, Accrual 100000000,000000
CreateCoinStakeHashboinc: 46f64d69eb8c5ee9cd24178b589af83f<|><|><|>0<|>0.00000<|>0<|><|><|>0<|>0<|>v3.5.8.8-g-research<|>1.00<|>1495641440<|>24998<|>46f64d69eb8c5ee9cd24178b589af83fc23b65cc423b6d6a99393f38693e3e6d9b3e67c9399e3f353d3c6666ca37969a75706e62746373706541627b66752f746c<|>25<|>S6WtsHxuDUmSFYgb56Vjw7nvYsGJvKrWHb<|>775c9d2faca92ca43b94b16c54587a688938ee6705a4afec15cf90301570f481<|>0.00<|><|><|><|><|>1.00<|>0.000000<|>0.000000<|>0.00<|>0<|><|>04b65db25b5c2af68ff5a60ffec6e01275af9a3327331c53877d3ac037a471dba2f6855cb10247dee5e695b7def96ddc8165e7008f935bff77d0b298ea70b3fefe<|>
Creating POS Reward for 46f64d69eb8c5ee9cd24178b589af83f  mint  1,000001  {RSAWeight 25023,000000}  Research 1,000000, Interest 0,000000
added gridcoin reward to coinstake
Signing BoincBlock for cpid 46f64d69eb8c5ee9cd24178b589af83f and blockhash 775c9d2faca92ca43b94b16c54587a688938ee6705a4afec15cf90301570f481 with sig MEUCIQDLXhvEsLYvg6cDfJwDQNXuvz6T9kfFB8+W6EATJecOmgIgL6g8eOOwQR4AS8gXqOytq24Pmm7uFUqMJXWU6wj+kRY=
signed boinchash, coinstake, wholeblock

 Newbie Special First Stake for CPID 46f64d69eb8c5ee9cd24178b589af83f, Age 19,149144, Accrual 100000000,000000
****CheckBlock[]: Total Mint too Small 46f64d69eb8c5ee9cd24178b589af83f, mint 100,000000, Res 1,000000, Interest 0,000000, hash 46f64d69eb8c5ee9cd24178b589af83f<|><|><|>0<|>0.00000<|>0<|><|><|>0<|>0<|>v3.5.8.8-g-research<|>1.00<|>1495641440<|>24998<|>46f64d69eb8c5ee9cd24178b589af83fc23b65cc423b6d6a99393f38693e3e6d9b3e67c9399e3f353d3c6666ca37969a75706e62746373706541627b66752f746c<|>25<|>S6WtsHxuDUmSFYgb56Vjw7nvYsGJvKrWHb<|>775c9d2faca92ca43b94b16c54587a688938ee6705a4afec15cf90301570f481<|>0.00<|><|><|><|><|>1.00<|>0.000000<|>0.000000<|>0.00<|>0<|><|>04b65db25b5c2af68ff5a60ffec6e01275af9a3327331c53877d3ac037a471dba2f6855cb10247dee5e695b7def96ddc8165e7008f935bff77d0b298ea70b3fefe<|>MEUCIQCgwqeaZ/2dIIzJ+OIuutIWdFMT/kORoXVPQyfxwv91FwIgHsjWgBRy/OaGBC4AokHcncVg6YQD0JGid1qhq1Ycc8E=
ERROR: ****CheckBlock[]: Total Mint too Small 46f64d69eb8c5ee9cd24178b589af83f, mint 100,000000, Res 1,000000, Interest 0,000000, hash 46f64d69eb8c5ee9cd24178b589af83f<|><|><|>0<|>0.00000<|>0<|><|><|>0<|>0<|>v3.5.8.8-g-research<|>1.00<|>1495641440<|>24998<|>46f64d69eb8c5ee9cd24178b589af83fc23b65cc423b6d6a99393f38693e3e6d9b3e67c9399e3f353d3c6666ca37969a75706e62746373706541627b66752f746c<|>25<|>S6WtsHxuDUmSFYgb56Vjw7nvYsGJvKrWHb<|>775c9d2faca92ca43b94b16c54587a688938ee6705a4afec15cf90301570f481<|>0.00<|><|><|><|><|>1.00<|>0.000000<|>0.000000<|>0.00<|>0<|><|>04b65db25b5c2af68ff5a60ffec6e01275af9a3327331c53877d3ac037a471dba2f6855cb10247dee5e695b7def96ddc8165e7008f935bff77d0b298ea70b3fefe<|>MEUCIQCgwqeaZ/2dIIzJ+OIuutIWdFMT/kORoXVPQyfxwv91FwIgHsjWgBRy/OaGBC4AokHcncVg6YQD0JGid1qhq1Ycc8E=

ERROR: ProcessBlock() : CheckBlock FAILED

@tomasbrod
Copy link
Member Author

tomasbrod commented May 29, 2017

Happened 2 more times on my testnet node. The newbie block was staked just after restart of the wallet.
And I just want to make clear that this behavior destroys the owed research reward.

@denravonska
Copy link
Member

What about #332? It would "solve" this :)

@tomasbrod
Copy link
Member Author

I am afraid it wont. You would still get 1 GRC newbie reward, but without the newbie weight boost.

@tomasbrod
Copy link
Member Author

This issue is related to #225.

@tomasbrod
Copy link
Member Author

tomasbrod commented Jun 5, 2017

#225 Does NOT fix this issue.
Edit: Sorry, I had the wrong exe loaded in my debugger.
I added debug print to my PR to show rsaweight. It should match your magnitude.
Your commit @denravonska does fix this. Closing as SOLVED.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants