Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add LevelDB CMake detection #2701

Closed

Conversation

Kangie
Copy link

@Kangie Kangie commented Sep 11, 2023

While updating a Gentoo ebuild to use the new CMake builds I encountered some nasty red text and an inability to proceed with the build. This PR adds the missing Findleveldb.cmake and makes it useful.

@Kangie
Copy link
Author

Kangie commented Sep 11, 2023

I'm happy to drop this based on advice:

set(LIBLEVELDB leveldb)

However it caused issues testing against an older version of LevelDB on my system (1.20) and doesn't appear to cause any build issues (i.e. tests still pass, etc).

@div72
Copy link
Member

div72 commented Oct 7, 2023

@Kangie System LevelDB detection seem to work with the *.cmake provided by dev-libs/leveldb package on Gentoo, why is this patch necessary?

@Kangie
Copy link
Author

Kangie commented Oct 7, 2023

@Kangie System LevelDB detection seem to work with the *.cmake provided by dev-libs/leveldb package on Gentoo, why is this patch necessary?

I couldn't make it work when building via portage (or iirc locally). I can retest that over the next week.

@CyberTailor
Copy link
Contributor

LevelDB detection works without this patch via system-installed *.cmake files

@div72
Copy link
Member

div72 commented Jan 30, 2024

LevelDB detection works without this patch via system-installed *.cmake files

Closing then. @Kangie Please re-open if you can reproduce.

@div72 div72 closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants