net, consensus: Ban nodes 5.4.5.0 and below #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frigyes06
reviewed
Mar 13, 2024
Frigyes06
approved these changes
Mar 13, 2024
barton2526
approved these changes
Mar 13, 2024
jamescowens
added a commit
to jamescowens/Gridcoin-Research
that referenced
this pull request
Mar 13, 2024
Added - net, consensus: Ban nodes 5.4.5.0 and below gridcoin-community#2751 (@jamescowens) Changed Removed Fixed - util: Adjust Fraction class addition overload overflow tests gridcoin-community#2748 (@jamescowens)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the unintended fork that occurred at 3190603/4 on mainnet due to a coding mistake where TxMessage contracts were constructed at version 3 instead of 2 before the block v13 hard fork point, which is not set yet, at this point since most nodes have moved over to 5.4.6.0 with the implicit protocol change that implies, we need to automatically disconnect nodes at versions between 5.4.0.0 and 5.4.5.0, in addition to the disconnect that already exists for out of date protocol version, which covers < 5.4.0.0 nodes (i.e. prior to the last mandatory).
This effectively makes 5.4.6.0 a mandatory. Introducing a formal mandatory at this point and incrementing the protocol version will not help us in this case, because the protocol version was NOT incremented between 5.4.5.0 and 5.4.6.0.