Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the cancel button #333

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Updates the cancel button #333

merged 3 commits into from
Jan 25, 2024

Conversation

EstherDarkish
Copy link
Contributor

@EstherDarkish EstherDarkish commented Jan 19, 2024 •
edited
Loading

Updates the cancel button
3c50ad2 
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
This was referenced Jan 19, 2024
Merged
Merged
@ghazwarhili ghazwarhili self-requested a review January 19, 2024 13:03
@EstherDarkish EstherDarkish changed the title Updates the cancel button Draft : Updates the cancel button Jan 22, 2024
@EstherDarkish EstherDarkish changed the title Draft : Updates the cancel button WIP Updates the cancel button Jan 22, 2024
Use the correct styling method to define theme for a commons-ui compo…
ca8bcfb 
…nent

Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
@EstherDarkish EstherDarkish changed the title WIP Updates the cancel button Updates the cancel button Jan 23, 2024
ghazwarhili
ghazwarhili approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@ghazwarhili ghazwarhili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review => OK

@EstherDarkish EstherDarkish merged commit c51f36e into main Jan 25, 2024
2 checks passed
@EstherDarkish EstherDarkish deleted the update_cancel_button branch January 25, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anistouri anistouri anistouri approved these changes

@ghazwarhili ghazwarhili ghazwarhili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EstherDarkish @ghazwarhili @anistouri