New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow editing description from filter edition dialogs #660

Merged

basseche merged 15 commits into main from allow_description_edition

Jan 9, 2025

Contributor

basseche commented Jan 2, 2025

No description provided.


          Allow editing description from filter edition dialogs

f9c482f

basseche self-assigned this


          add cpyright

d316401

This was referenced Jan 2, 2025

Case import : compute base name from case-server instead of front com… gridsuite/gridexplore-app#587

Merged

update filter request updates also element description. gridsuite/explore-server#114

Merged

Allow editing description from filter edition dialogs gridsuite/gridexplore-app#591

Merged


          remove duplicates

1b9f306

basseche force-pushed the allow_description_edition branch from f29a056 to 1b9f306 Compare

January 6, 2025 16:28

basseche added 4 commits

January 6, 2025 17:35


          refactor 2 : duplicates

5e653a2


          Filters Ok

c3ed496


          Merge branch 'main' into allow_description_edition

4dc80a5


          optional prop

a2da5f5

thangqp self-requested a review

January 8, 2025 09:09

basseche added 4 commits

January 8, 2025 10:14


          Merge branch 'main' into allow_description_edition

529089a


          remove elementUuid (same as id)

550debf

Fix

dc6e0ed


          add space

e656e10

thangqp reviewed

View reviewed changes

src/utils/constants/UIconstants.ts Outdated Show resolved Hide resolved

thangqp reviewed

View reviewed changes

src/components/filter/filter.type.ts Outdated Show resolved Hide resolved

thangqp reviewed

View reviewed changes

src/components/filter/FilterForm.tsx Outdated Show resolved Hide resolved

thangqp reviewed

View reviewed changes

src/components/inputs/reactHookForm/text/DescriptionField.tsx Outdated Show resolved Hide resolved

thangqp reviewed

View reviewed changes

src/components/inputs/reactHookForm/text/DescriptionField.tsx Outdated Show resolved Hide resolved

basseche added 2 commits

January 8, 2025 15:19


          review

59aa874


          export UiConstants

d154c96

thangqp reviewed

View reviewed changes

src/components/filter/expert/ExpertFilterEditionDialog.tsx Outdated Show resolved Hide resolved

thangqp self-requested a review

January 8, 2025 16:19

thangqp approved these changes

View reviewed changes


          Update src/components/filter/expert/ExpertFilterEditionDialog.tsx

fb9d7ef

Co-authored-by: Thang PHAM <117309322+thangqp@users.noreply.github.com>

EtienneLt approved these changes

View reviewed changes

Contributor

EtienneLt left a comment

test OK


          Merge branch 'main' into allow_description_edition

8043c6d

sonarqubecloud bot commented Jan 9, 2025

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

basseche merged commit db1cdc3 into main

5 checks passed

basseche deleted the allow_description_edition branch

January 9, 2025 10:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet