remove generic computation classes #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
7 tasks
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
thangqp
reviewed
Jun 20, 2024
| return Map.of( | ||
| HEADER_LIMIT_REDUCTION, | ||
| runContext.getLimitReduction() != null ? | ||
| runContext.getLimitReduction().toString() : | ||
| getRunContext().getLimitReduction() != null ? |
There was a problem hiding this comment.
Passing 'null' argument to parameter annotated as @NotNull
if (getRunContext().getLimitReduction() != null) {
return Map.of(HEADER_LIMIT_REDUCTION, getRunContext().getLimitReduction());
} else {
return super.getSpecificMsgHeaders();
}
Not really related but in line 48 and 51, using test by headers.containsKey() is not enough, the value can be null, pls correct line 48 and 51 as following way:
String limitReductionStr = headers.get(HEADER_LIMIT_REDUCTION);
Float limitReduction = limitReductionStr != null ? Float.parseFloat(limitReductionStr) : null
There was a problem hiding this comment.
Done. Damn null parameters in map.of won't get me again.
thangqp
reviewed
Jun 20, 2024
| @@ -66,11 +66,11 @@ public static LoadFlowResultContext fromMessage(Message<String> message, ObjectM | |||
| } | |||
|
|
|||
| @Override | |||
| protected Map<String, String> getSpecificMsgHeaders() { | |||
| protected Map<String, Object> getSpecificMsgHeaders() { | |||
There was a problem hiding this comment.
Why using Map<String, Object> instead of Map<String, String> (from AbstractResultContext)
There was a problem hiding this comment.
Leftover of the voltage init parsing mixup. Reverted. And ObjectMapper added.
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
…es' into remove-generic-computation-classes
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
thangqp
approved these changes
Jun 28, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now those classes will be in ws-commons