include node id in loadflow result #147
Conversation
jamal-khey
changed the title
jamal-khey
changed the title
| private LoadflowResultsUtils() { | ||
| } | ||
|
|
||
| public static String getIdFromViolation(LimitViolation limitViolation, Network network) { |
There was a problem hiding this comment.
getViolationLocationId ?
| .filter(Objects::nonNull) | ||
| .map(Bus::getId) | ||
| .distinct() | ||
| .toList(); |
There was a problem hiding this comment.
In nodebreaker we want busbar sections ids and not bus ids
There was a problem hiding this comment.
done in powsybl-ws-commons
|
|
||
| import static com.powsybl.security.ViolationLocation.Type.NODE_BREAKER; | ||
|
|
||
| public final class LoadflowResultsUtils { |
There was a problem hiding this comment.
Why all methods are public
It's used only by LoadFlowWorkerService
There was a problem hiding this comment.
this code has been moved to powsybl-ws-commons , to avoid duplicating it for security-analysis-server
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
| @@ -792,4 +790,53 @@ private static final class LimitViolationsMock { | |||
| new LimitViolation("NHV1_NHV2_2", "lineName2", LimitViolationType.CURRENT, "limit2", 300, 900, 0.7F, 1000, TwoSides.ONE), | |||
| new LimitViolation("NHV1_NHV2_2", "lineName2", LimitViolationType.CURRENT, "limit2", 300, 900, 0.7F, 1000, TwoSides.TWO)); | |||
| } | |||
|
|
|||
| private static final class VoltageLimitViolationsMock { | |||
There was a problem hiding this comment.
Why this static block ?
There was a problem hiding this comment.
i need results with ViolationLocation for the tests
| }); | ||
| assertEquals(2, limitViolations.size()); | ||
| // check that the subject id is equal to the Bus Id | ||
| assertEquals(limitViolations.get(0).getSubjectId(), "NHV1"); |
Signed-off-by: jamal-khey <myjamal89@gmail.com>
SlimaneAmar
force-pushed
the
jamal-khey/limit-violation-by-node
branch
from
d11c213 to
85f5c16
Compare
Signed-off-by: Slimane AMAR <amarsli@gm0winl104.bureau.si.interne>
SlimaneAmar
force-pushed
the
jamal-khey/limit-violation-by-node
branch
from
85f5c16 to
2e14a23
Compare
|
this pull request depend on powsybl-ws-communs