Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove previous load-flow report when we start a new one #73

Merged
merged 9 commits into from
Nov 23, 2023

Conversation

dbraquart
Copy link
Contributor

No description provided.

@dbraquart dbraquart changed the title WIP remove previous load-flow report when we start a new one remove previous load-flow report when we start a new one Nov 14, 2023
@@ -51,6 +51,7 @@ public ResponseEntity<UUID> run(@Parameter(description = "Network UUID") @PathVa
@Parameter(description = "Result receiver") @RequestParam(name = "receiver", required = false) String receiver,
@Parameter(description = "reportUuid") @RequestParam(name = "reportUuid", required = false) UUID reportId,
@Parameter(description = "reporterId") @RequestParam(name = "reporterId", required = false) String reportName,
@Parameter(description = "The type of report for short-circuit") @RequestParam(name = "reportType") String reportType,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

short-circuit ?

Objects.requireNonNull(reportUuid);

var path = UriComponentsBuilder.fromPath("{reportUuid}")
.queryParam(QUERY_PARAM_REPORT_TASKKEY_TYPE_FILTER, taskKeyTypeFilter)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename QUERY_PARAM_REPORT_TASKKEY_TYPE_FILTER by QUERY_PARAM_REPORT_TYPE_FILTER
QUERY_PARAM_REPORT_TYPE_FILTER = "reportType"

@@ -51,6 +51,7 @@ public ResponseEntity<UUID> run(@Parameter(description = "Network UUID") @PathVa
@Parameter(description = "Result receiver") @RequestParam(name = "receiver", required = false) String receiver,
@Parameter(description = "reportUuid") @RequestParam(name = "reportUuid", required = false) UUID reportId,
@Parameter(description = "reporterId") @RequestParam(name = "reporterId", required = false) String reportName,
@Parameter(description = "The type of report for short-circuit") @RequestParam(name = "reportType") String reportType,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional ?

@EstherDarkish EstherDarkish self-requested a review November 20, 2023 16:22
Copy link
Contributor

@EstherDarkish EstherDarkish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test OK code OK

…logs

# Conflicts:
#	src/main/java/org/gridsuite/loadflow/server/service/LoadFlowWorkerService.java
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

@dbraquart dbraquart merged commit cf5cd15 into main Nov 23, 2023
4 checks passed
@dbraquart dbraquart deleted the separate_computation_logs_from_modification_logs branch November 23, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants