Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add actual and upcoming overload : limitViolationInfos #74

Merged
merged 10 commits into from
Nov 21, 2023
Merged

Add actual and upcoming overload : limitViolationInfos #74

merged 10 commits into from
Nov 21, 2023

Conversation

souissimai
Copy link
Contributor

No description provided.

@souissimai
add actual and upcoming overload : limitViolationInfos
7108eb4 
Signed-off-by: Maissa SOUISSI <maissa.souissi@rte-france.com>
@souissimai
add changeset
7067b8b 
Signed-off-by: Maissa SOUISSI <maissa.souissi@rte-france.com>
@souissimai
fix code smells
f3ea51b 
Signed-off-by: Maissa SOUISSI <maissa.souissi@rte-france.com>
@souissimai
UnitTests
1ff010c 
Signed-off-by: Maissa SOUISSI <maissa.souissi@rte-france.com>
@souissimai
TU
6c14621 
Signed-off-by: Maissa SOUISSI <maissa.souissi@rte-france.com>
@souissimai
TU coverage
868e8df 
Signed-off-by: Maissa SOUISSI <maissa.souissi@rte-france.com>
@souissimai
fixes
d125883 
Signed-off-by: Maissa SOUISSI <maissa.souissi@rte-france.com>
@souissimai
replace field acceptable_duration by actual_overload and add up_comin…
8f15370 
…g_overload field

Signed-off-by: Maissa SOUISSI <maissa.souissi@rte-france.com>
FranckLecuyer
FranckLecuyer requested changes Nov 20, 2023
View reviewed changes
src/main/java/org/gridsuite/loadflow/server/dto/LimitViolationInfos.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/loadflow/server/dto/LimitViolationInfos.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/loadflow/server/service/LoadFlowWorkerService.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/loadflow/server/service/LoadFlowWorkerService.java
TwoWindingsTransformer twoWindingsTransformer = network.getTwoWindingsTransformer(equipmentId);
if (twoWindingsTransformer != null) {
tempLimit = handleEquipmentLimitViolation(twoWindingsTransformer, limitViolationInfo);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider also the three windings transformer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with PO and Techlead, we will not consider three windings transformer

src/main/java/org/gridsuite/loadflow/server/service/LoadFlowWorkerService.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/loadflow/server/service/LoadFlowWorkerService.java Outdated Show resolved Hide resolved
@souissimai souissimai removed the request for review from anistouri November 20, 2023 11:23
dbraquart
dbraquart requested changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@dbraquart dbraquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: some changes requested
tests: ok (still testing tho)

src/main/java/org/gridsuite/loadflow/server/dto/LimitViolationInfos.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/loadflow/server/service/LoadFlowWorkerService.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/loadflow/server/service/LoadFlowWorkerService.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/loadflow/server/service/LoadFlowWorkerService.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/loadflow/server/service/LoadFlowWorkerService.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/loadflow/server/service/LoadFlowWorkerService.java Outdated Show resolved Hide resolved
@souissimai
requested values
0dc13d2 
Signed-off-by: Maissa SOUISSI <maissa.souissi@rte-france.com>
dbraquart
dbraquart requested changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@dbraquart dbraquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: another rename requested
tests: ok

remark: Existing LF computation results cannot be displayed correctly using the new format. Did we plan to migrate the results (complex!), to remove all LF results (admin-tool script), to do nothing ?

src/main/java/org/gridsuite/loadflow/server/service/LoadFlowWorkerService.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/loadflow/server/service/LoadFlowWorkerService.java Show resolved Hide resolved
@souissimai
rename method
12fdb41 
Signed-off-by: Maissa SOUISSI <maissa.souissi@rte-france.com>
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.6% 80.6% Coverage
0.0% 0.0% Duplication

@dbraquart dbraquart self-requested a review November 20, 2023 16:25
dbraquart
dbraquart approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@dbraquart dbraquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: ok
tests: not done with last commit

@souissimai souissimai merged commit 999ea91 into main Nov 21, 2023
4 checks passed
@souissimai souissimai deleted the adjust_loadFlow_results_limit_violations branch November 21, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbraquart dbraquart dbraquart approved these changes

@FranckLecuyer FranckLecuyer FranckLecuyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@souissimai @FranckLecuyer @dbraquart