Add loadflow parameters controller #82

ayolab · 2023-12-26T08:34:58Z

Linked to:

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

AbdelHedhili

depending on what we do with my remark on study-server we might need to change the api

src/main/java/org/gridsuite/loadflow/server/entities/parameters/LoadFlowParametersEntity.java

.../java/org/gridsuite/loadflow/server/entities/parameters/LoadFlowSpecificParameterEntity.java

...java/org/gridsuite/loadflow/server/repositories/parameters/LoadFlowParametersRepository.java

src/main/java/org/gridsuite/loadflow/server/service/parameters/LoadFlowParametersService.java

src/test/java/org/gridsuite/loadflow/server/LoadFlowParametersTest.java

src/test/java/org/gridsuite/loadflow/utils/assertions/DTOAssert.java

src/test/java/org/gridsuite/loadflow/utils/assertions/Assertions.java

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

ayolab · 2024-01-10T15:43:21Z

depending on what we do with my remark on study-server we might need to change the api

I added a new endpoint that allows creating default parameters

src/main/java/org/gridsuite/loadflow/server/LoadFlowParametersController.java

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

src/main/java/org/gridsuite/loadflow/server/LoadFlowController.java

src/main/java/org/gridsuite/loadflow/server/LoadFlowParametersController.java

src/main/java/org/gridsuite/loadflow/server/service/parameters/LoadFlowParametersService.java

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

AbdelHedhili

fix sonar issue about method with 10 parameters (for exemple you can add a class to handle some parameters ; https://github.com/gridsuite/network-modification-server/blob/main/src/main/java/org/gridsuite/modification/server/dto/ReportInfos.java)

src/main/java/org/gridsuite/loadflow/server/LoadFlowController.java

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

src/main/java/org/gridsuite/loadflow/server/service/parameters/LoadFlowParametersService.java

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

src/main/java/org/gridsuite/loadflow/server/LoadFlowParametersController.java

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

SlimaneAmar · 2024-01-24T15:05:50Z

src/main/java/org/gridsuite/loadflow/server/entities/parameters/LoadFlowParametersEntity.java

+                .build();
+    }
+
+    public LoadFlowParametersEntity copy() {


SlimaneAmar · 2024-01-24T15:31:59Z

Good job !

src/main/java/org/gridsuite/loadflow/server/dto/parameters/LoadFlowParametersInfos.java

src/main/java/org/gridsuite/loadflow/server/dto/parameters/LoadFlowParametersValues.java

src/main/java/org/gridsuite/loadflow/server/service/parameters/LoadFlowParametersService.java

src/test/java/org/gridsuite/loadflow/server/LoadFlowParametersTest.java

Tristan-WorkGH · 2024-01-25T09:49:48Z

src/test/java/org/gridsuite/loadflow/utils/assertions/DTOAssert.java

+/**
+ *  @author Ayoub LABIDI <ayoub.labidi at rte-france.com>
+ */
+public class DTOAssert<T> extends AbstractAssert<DTOAssert<T>, T> {


good 👏🏻

src/main/java/org/gridsuite/loadflow/server/LoadFlowParametersController.java

Tristan-WorkGH · 2024-01-25T10:07:09Z

src/main/java/org/gridsuite/loadflow/server/LoadFlowParametersController.java

+    @Operation(summary = "Get all parameters")
+    @ApiResponse(responseCode = "200", description = "The list of all parameters was returned")
+    public ResponseEntity<List<LoadFlowParametersInfos>> getAllParameters() {
+        return ResponseEntity.ok().body(parametersService.getAllParameters());


Suggested change

return ResponseEntity.ok().body(parametersService.getAllParameters());

return ResponseEntity.ok().contentType(MediaType.APPLICATION_JSON).body(parametersService.getAllParameters());

Tristan-WorkGH · 2024-01-25T10:11:39Z

src/main/java/org/gridsuite/loadflow/server/entities/parameters/LoadFlowParametersEntity.java

+@NoArgsConstructor
+@AllArgsConstructor


To have a constructor without default values

Suggested change

@NoArgsConstructor

@AllArgsConstructor

@NoArgsConstructor

@AllArgsConstructor

@RequiredArgsConstructor

src/main/java/org/gridsuite/loadflow/server/entities/parameters/LoadFlowParametersEntity.java

Tristan-WorkGH · 2024-01-25T10:16:29Z

.../java/org/gridsuite/loadflow/server/entities/parameters/LoadFlowSpecificParameterEntity.java

+@Table(name = "loadFlowSpecificParameters", indexes = {
+    @Index(name = "loadFlowParametersEntity_specificParameters_index", columnList = "load_flow_parameters_id")
+})
+public class LoadFlowSpecificParameterEntity {


myabe add a //TODO to remember to rename entity field after the data migration?

src/main/resources/db/changelog/changesets/changelog_20240124T152518Z.xml

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

Tristan-WorkGH · 2024-01-26T12:30:32Z

src/main/java/org/gridsuite/loadflow/server/service/parameters/LoadFlowParametersService.java

+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+package org.gridsuite.loadflow.server.service.parameters;


Why in a sub-package?

src/main/java/org/gridsuite/loadflow/server/service/parameters/LoadFlowParametersService.java

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

sonarqubecloud · 2024-01-26T15:11:24Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
83.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ayolab added 8 commits December 26, 2023 09:33

Add loadflow parameters controller

fb204da

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

clean code

193e1b9

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

Add duplication endpoint

5eb78ef

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

fix unit tests

c596fdb

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

add unit tests

5081351

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

add unit tests

c44894c

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

Fix run loadFlow with default params

323cf33

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

Merge branch main

acc0b87

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

ayolab requested review from AbdelHedhili and SlimaneAmar January 8, 2024 08:58

AbdelHedhili reviewed Jan 8, 2024

View reviewed changes

ayolab added 2 commits January 10, 2024 16:12

add create default params endpoint

27b88c8

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

Requested changes

d08049d

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

ayolab requested a review from AbdelHedhili January 10, 2024 15:42

AbdelHedhili reviewed Jan 12, 2024

View reviewed changes

src/main/java/org/gridsuite/loadflow/server/LoadFlowParametersController.java Outdated Show resolved Hide resolved

Requested change

f112ae2

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

ayolab requested a review from AbdelHedhili January 15, 2024 14:19

Fix code smells

84fec28

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

flomillot reviewed Jan 16, 2024

View reviewed changes

ayolab added 3 commits January 16, 2024 16:48

Requested changes

6bf5b02

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

Merge branch main

89f0151

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

Fix checkStyle

3fc08d9

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

AbdelHedhili requested changes Jan 17, 2024

View reviewed changes

src/main/java/org/gridsuite/loadflow/server/LoadFlowController.java Outdated Show resolved Hide resolved

Fix code smells

228805d

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

ayolab requested review from AbdelHedhili and flomillot January 17, 2024 09:21

flomillot reviewed Jan 17, 2024

View reviewed changes

src/main/java/org/gridsuite/loadflow/server/service/parameters/LoadFlowParametersService.java Outdated Show resolved Hide resolved

src/main/java/org/gridsuite/loadflow/server/service/parameters/LoadFlowParametersService.java Outdated Show resolved Hide resolved

Requested changes

b8d78de

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

ayolab requested a review from flomillot January 17, 2024 12:22

flomillot approved these changes Jan 17, 2024

View reviewed changes

SlimaneAmar reviewed Jan 24, 2024

View reviewed changes

src/main/java/org/gridsuite/loadflow/server/LoadFlowParametersController.java Outdated Show resolved Hide resolved

rename columns and modify duplicate path

ded3688

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

SlimaneAmar approved these changes Jan 24, 2024

View reviewed changes

Tristan-WorkGH mentioned this pull request Jan 25, 2024

Add script to migrate parameters gridsuite/deployment#372

Merged

Tristan-WorkGH assigned ayolab Jan 25, 2024

Tristan-WorkGH requested changes Jan 25, 2024

View reviewed changes

Tristan-WorkGH approved these changes Jan 25, 2024

View reviewed changes

Tristan-WorkGH requested changes Jan 25, 2024

View reviewed changes

ayolab added 2 commits January 26, 2024 10:02

Requested changes

806bf1e

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

Requested changes

f317f1e

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

ayolab requested a review from Tristan-WorkGH January 26, 2024 10:58

fix liquibase checksum

ade497b

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

Tristan-WorkGH approved these changes Jan 26, 2024

View reviewed changes

Remove whitespace

51e5df0

Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>

AbdelHedhili approved these changes Jan 26, 2024

View reviewed changes

ayolab merged commit 15ac580 into main Jan 26, 2024
3 checks passed

ayolab deleted the add_loadflow_parameters_controller branch January 26, 2024 15:20

flomillot mentioned this pull request Jan 29, 2024

Migration of the parameters from study-server gridsuite/sensitivity-analysis-server#59

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add loadflow parameters controller #82

Add loadflow parameters controller #82

ayolab commented Dec 26, 2023 •

edited by Tristan-WorkGH

Loading

AbdelHedhili left a comment

ayolab commented Jan 10, 2024

AbdelHedhili left a comment

SlimaneAmar Jan 24, 2024

SlimaneAmar commented Jan 24, 2024

Tristan-WorkGH Jan 25, 2024

Tristan-WorkGH Jan 25, 2024

Tristan-WorkGH Jan 25, 2024

Tristan-WorkGH Jan 25, 2024

Tristan-WorkGH Jan 26, 2024

sonarqubecloud bot commented Jan 26, 2024

	return ResponseEntity.ok().body(parametersService.getAllParameters());
	return ResponseEntity.ok().contentType(MediaType.APPLICATION_JSON).body(parametersService.getAllParameters());

Add loadflow parameters controller #82

Add loadflow parameters controller #82

Conversation

ayolab commented Dec 26, 2023 • edited by Tristan-WorkGH Loading

AbdelHedhili left a comment

Choose a reason for hiding this comment

ayolab commented Jan 10, 2024

AbdelHedhili left a comment

Choose a reason for hiding this comment

SlimaneAmar Jan 24, 2024

Choose a reason for hiding this comment

SlimaneAmar commented Jan 24, 2024

Tristan-WorkGH Jan 25, 2024

Choose a reason for hiding this comment

Tristan-WorkGH Jan 25, 2024

Choose a reason for hiding this comment

Tristan-WorkGH Jan 25, 2024

Choose a reason for hiding this comment

Tristan-WorkGH Jan 25, 2024

Choose a reason for hiding this comment

Tristan-WorkGH Jan 26, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 26, 2024

Quality Gate passed

ayolab commented Dec 26, 2023 •

edited by Tristan-WorkGH

Loading