-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration of the parameters from study-server #59
Conversation
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
Best pratices
|
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
… to return SensitivityAnalysisParametersInfos directly instead of Optional. Signed-off-by: Florent MILLOT <millotflo@gmail.com>
# Conflicts: # src/main/java/org/gridsuite/sensitivityanalysis/server/SensitivityAnalysisController.java # src/main/java/org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisService.java # src/main/java/org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisWorkerService.java # src/main/resources/db/changelog/db.changelog-master.yaml
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
|
# Conflicts: # src/main/java/org/gridsuite/sensitivityanalysis/server/SensitivityAnalysisController.java # src/main/java/org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisService.java # src/test/java/org/gridsuite/sensitivityanalysis/server/SensitivityAnalysisControllerTest.java # src/test/java/org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisServiceTest.java
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
…fields. Signed-off-by: Florent MILLOT <millotflo@gmail.com>
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code : ok, but can you check if you can resolve some sonar issue
Unfortunately it's issues already present. For the number of params, it's allowed if it's for methods called by the controller if I remember well. |
This reverts commit a626798.
src/main/java/org/gridsuite/sensitivityanalysis/server/SensitivityAnalysisController.java
Show resolved
Hide resolved
...uite/sensitivityanalysis/server/entities/parameters/SensitivityAnalysisParametersEntity.java
Show resolved
Hide resolved
...a/org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisParametersService.java
Show resolved
Hide resolved
src/main/java/org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisService.java
Outdated
Show resolved
Hide resolved
.../java/org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisWorkerService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
# Conflicts: # src/main/resources/db/changelog/db.changelog-master.yaml # src/test/java/org/gridsuite/sensitivityanalysis/server/SensitivityAnalysisControllerTest.java
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
…java Signed-off-by: Florent MILLOT <millotflo@gmail.com>
…Infos and toEntity methods. Signed-off-by: Florent MILLOT <millotflo@gmail.com>
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 4 New issues |
No description provided.