Reuse EntryGroup - reset+(re)commit #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grishy
added a commit
that referenced
this pull request
Nov 20, 2024
Reuse EntryGroup - reset+(re)commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #13
This is not a perfect solution. The application creates and reuses a single entity group in avahi. This is good because it doesn't need to recreate EG every time, but if avahi restarts and flushes the state, the go-avahi-cname will also go out (exit with error).
This can be fixed by monitoring and recreating the group every time. Perhaps later I will implement this method.
For now, I'm fine with restarting if avahi restarted. 😄