Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix $IF_IP_FORWARDING check in vmrouter #5

Open
skalkoto opened this issue May 30, 2017 · 1 comment
Open

Fix $IF_IP_FORWARDING check in vmrouter #5

skalkoto opened this issue May 30, 2017 · 1 comment

Comments

@skalkoto
Copy link
Collaborator

Right now, the vmrouter script checks the ip-forwarding interface variable like this:

if [ -n "$IF_IP_FORWARDING" ]; then
...
fi

This means that the variable will be treated as being set if it is non-empty. We should probably check its value like this: [ "$IF_IP_FORWARDING" = 1 ] to prevent errors. People would expect that by setting the value to 0 they would disable ip forwarding.

@kargig
Copy link
Contributor

kargig commented Jun 14, 2017

this seems reasonable, let's make this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants