Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why fill="none" is removed in generate-icons script #318

Open
taysea opened this issue Jun 15, 2023 · 0 comments
Open

Investigate why fill="none" is removed in generate-icons script #318

taysea opened this issue Jun 15, 2023 · 0 comments

Comments

@taysea
Copy link
Collaborator

taysea commented Jun 15, 2023

Currently, instances of fill="none" are getting removed by the generate-icons script.

Ideally, we should be able to edit the .svg files as source of truth and let generate-icons convert these into react components. Right now, we have to edit the .js files and not run generate-icons otherwise fill="none" will get removed: #317

Some potential avenues to explore are the plugins related to svgo (I tried with little success):

Related to #298 #263 #310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant