-
Notifications
You must be signed in to change notification settings - Fork 35
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
58721d2
commit 981d4e7
Showing
1 changed file
with
21 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
981d4e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keeganwitt FWIW, it's a really bad idea to steal someone's improvement. The way to do that is to keep the author as shown in https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors for example. This usually happens automatically if you cherry-pick or merge...
981d4e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I should have cherry-picked it over then made the edits I did on top of it. I got in a hurry and didn't think about it. I'd used the word "stealing" as a jovial way of giving credit and wasn't trying to imply I was trying to take someone's work without credit. But I now recognize my hasty choice must have felt exactly like that. I'll be more careful in the future.