-
-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow hcl format from stdin #3288
Draft
alikhil
wants to merge
13
commits into
gruntwork-io:main
Choose a base branch
from
alikhil:feature/hclfmt-stdin-2926
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+127
−4
Draft
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6545a8b
Allow formating from stdin
alikhil 424b42a
Update cli/commands/hclfmt/action_test.go
alikhil 5812bd1
Change os.TempDir() to t.TempDir()
alikhil f02e5c1
Merge branch 'feature/hclfmt-stdin-2926' of github.com:alikhil/terrag…
alikhil 429a3c3
Fix lint error
alikhil ea32585
Merge branch 'master' into feature/hclfmt-stdin-2926
alikhil c2515b2
Merge branch 'master' into feature/hclfmt-stdin-2926
alikhil 15bdfa2
Try fix lint error
alikhil ac79534
Merge branch 'gruntwork-io:main' into feature/hclfmt-stdin-2926
alikhil af315df
Fix lint issues
alikhil e9e0d4f
Merge branch 'master' into feature/hclfmt-stdin-2926
alikhil 4d6c1a5
Refactor
alikhil 8ca772b
Fix clone function
alikhil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
inputs = { | ||
# comments | ||
foo = "bar" | ||
bar = "baz" | ||
|
||
inputs = "disjoint" | ||
disjoint = true | ||
|
||
listInput = [ | ||
"foo", | ||
"bar", | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
inputs = { | ||
# comments | ||
foo = "bar" | ||
bar="baz" | ||
|
||
inputs = "disjoint" | ||
disjoint = true | ||
|
||
listInput = [ | ||
"foo", | ||
"bar", | ||
] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing integration test to validate end-to-end usage of
--terragrunt-hclfmt-stdin
flag, for example I commented lines 37-42 and all tests pass...Examples:
https://github.com/gruntwork-io/terragrunt/blob/main/test/integration_download_test.go#L260
https://github.com/gruntwork-io/terragrunt/blob/main/test/integration_test.go