Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow player to trigger desync on purpose in examples #62

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

PraxTube
Copy link
Contributor

Added a function in the examples to trigger a desync by moving player 1 to the origin in local session only. This will create a desync which can be useful to simply see and understand the output. Maybe you don't want to merge this, but I think it's quite useful for people to quickly see how a desync will be detected (otherwise it's quite hard to get an actual desync).

You possibly want to change the way the function is called.

@gschup
Copy link
Owner

gschup commented Oct 19, 2023

I think a functionality like this is actually quite useful, but it needs a prominent explainer for the player. Maybe on the bottom of the playing area, we should display a string along the lines of: "Hit SPACE to cause a desync!"

Copy link
Owner

@gschup gschup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I think this is a nifty little inclusion to demonstrate desyncs. Thanks!

@gschup gschup merged commit a9d3cf0 into gschup:main Oct 23, 2023
2 checks passed
@PraxTube
Copy link
Contributor Author

👍 I might work on a lot more documentation-ish work in the future, but for now I have other things I must focus on (and I first need to get a better understanding of how things work anyways).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants