-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: naming conventions #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to get this fixed :)
@@ -94,7 +94,7 @@ In this document, all remarkable changes are listed. Not mentioned are smaller c | |||
|
|||
## 0.4.2 | |||
|
|||
- users are now allowed to save `None` buffers for a `GGRSRequest::SaveRequest`. This allows users to keep their own state history and load/save more efficiently | |||
- users are now allowed to save `None` buffers for a `GgrsRequest::SaveRequest`. This allows users to keep their own state history and load/save more efficiently |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe skip the changelog, since we can't change naming for released versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should remain as is. It's more of a historical listing than anything else :)
Co-authored-by: Johan Klokkhammer Helsing <johanhelsing@gmail.com>
Co-authored-by: Johan Klokkhammer Helsing <johanhelsing@gmail.com>
To prepare for the next release, it's time to introduce breaking changes!
According to the rust naming conventions, Acronyms should not be fully uppercase. We already do this in bevy_ggrs, now it is time to also implement that change here.
GGRSError
toGgrsError
GGRSEvent
toGgrsEvent
GGRSRequest
toGgrsRequest
GgrsError
variants