Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad performance of script command tracing #751

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Fix bad performance of script command tracing #751

merged 3 commits into from
Sep 18, 2024

Conversation

Pirulax
Copy link
Collaborator

@Pirulax Pirulax commented Jul 16, 2024

  • Use snprintf_s instead of std::format (Much better peformance in debug at least)
  • Add option script-tracing to premake

yukani
yukani approved these changes Sep 17, 2024
View reviewed changes
source/game_sa/Scripts/TheScripts.h Outdated Show resolved Hide resolved
@Pirulax @yukani
Update source/game_sa/Scripts/TheScripts.h
1492221 
Co-authored-by: yukani <yukani@zohomail.eu>
@Pirulax Pirulax merged commit 49238f1 into gta-reversed:master Sep 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukani yukani yukani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pirulax @yukani