Fix bad performance of script command tracing

premake5.lua

@@ -8,6 +8,10 @@
     Options and Actions
 --]]
 
+newoption {
+    trigger     = "script-tracing",
+    description = "Enable script command trace logging (Slow!)"
+}
 newoption {
     trigger     = "outdir",
     value       = "path",

source/game_sa/Scripts/RunningScript.cpp

@@ -916,7 +916,13 @@ OpcodeResult CRunningScript::ProcessOneCommand() {
         };
     } op = { CTheScripts::Read2BytesFromScript(m_IP) };
 
-    SPDLOG_LOGGER_TRACE(logger, "[{}][IP: {:#x} + {:#x}]: {} [{:#x}]", m_szName, LOG_PTR(m_pBaseIP), LOG_PTR(m_IP - m_pBaseIP), notsa::script::GetScriptCommandName((eScriptCommands)op.command), (size_t)op.command);
+#ifdef NOTSA_SCRIPT_TRACING
+    // snprintf is faster (in debug at least) - Gotta stick to it for now
+    char msg[4096];
+    sprintf_s(msg, "[%s][IP: 0x%X + 0x%X]: %s [0x%X]", m_szName, LOG_PTR(m_pBaseIP), LOG_PTR(m_IP - m_pBaseIP), notsa::script::GetScriptCommandName((eScriptCommands)op.command).data(), (size_t)op.command);
+    SPDLOG_LOGGER_TRACE(logger, msg);
+    //SPDLOG_LOGGER_TRACE(logger, "[{}][IP: {:#x} + {:#x}]: {} [{:#x}]", m_szName, LOG_PTR(m_pBaseIP), LOG_PTR(m_IP - m_pBaseIP), notsa::script::GetScriptCommandName((eScriptCommands)op.command), (size_t)op.command);
+#endif
 
     m_bNotFlag = op.notFlag;
 

source/game_sa/Scripts/TheScripts.h

@@ -253,7 +253,7 @@ struct tScriptSearchlight {
         m_Tower            = nullptr;
         m_Housing          = nullptr;
         m_Bulb             = nullptr;
-        m_TargetSpot       = nullptr;
+        m_TargetSpot       = CVector{};
         vf64               = CVector{};
         vf70               = CVector{};
     }

source/premake5.lua

@@ -41,6 +41,10 @@ project "gta_sa_modern"
         "../libs/tracy/public",
         "../libs/json/include"
     }
+
+    filter "options:script-tracing"
+        defines { "NOTSA_SCRIPT_TRACING" }
+    filter {}
 
     defines { 
         "NOMINMAX",