Reverse JPegCompress plugin #782
Open
+168
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pirulax
requested changes
Oct 6, 2024
| IWICBitmapFrameEncode* frame{}; | ||
| GUID format{ GUID_WICPixelFormat24bppBGR }; | ||
|
|
||
| #define HRCHK(hr) if (FAILED((hr))) { NOTSA_LOG_ERR("Couldn't encode screenshot. Your capture is not saved."); return; } |
There was a problem hiding this comment.
"Couldn't encode screenshot." might be misleading. I'd also include the status in the message.
Or perhaps just use VERIFY (or WIN_VERIFY? not sure)
|
|
||
| // 0x5D07A0 - unused | ||
| bool JPegDecompressToVramFromBuffer(RwRaster* raster, uint8** unk) { | ||
| static auto s_ScreenshotFileBuf = StaticRef<std::array<uint8, 204'800>>(0xBD0B78); |
There was a problem hiding this comment.
Do we need to use GTA's buffer here?
Or we can use our own?
| void JPegDecompressToRaster(RwRaster* raster, struct jpeg_source_mgr& src); | ||
| void JPegDecompressToVramFromBuffer(RwRaster* raster, RwInt8** unk); | ||
| // 0x5D07A0 | ||
| bool JPegDecompressToVramFromBuffer(RwRaster* raster, uint8** unk); |
There was a problem hiding this comment.
might as well just use byte instead
|
I just noticed that the sole reason of you adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reimplemented d3dx/libjpeg shit with wic