Bug fix for deprecated metadata.get_table_schema
#349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the bug described in gtalarico#314 Adds test case in `tests\test_api_table`
Issue during checks due to including a type in the test function
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 25 25
Lines 2025 2025
=======================================
Hits 2017 2017
Misses 8 8 ☔ View full report in Codecov by Sentry. |
|
Do we need to fix this bug? I'd planned on removing this module in the 3.0 release, and |
|
Not sure, I figured since #314 was still open and had been updated/labeled as |
|
Can't hurt to close the ticket, then. I'll merge it and do one more bugfix release before 3.0. Thanks for contributing! |
mesozoic
added a commit
to mesozoic/pyairtable
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug described in #314
Adds test case in
tests\test_api_table