Use datetime
instead of str
for all model timestamps
#352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch switches
Model.created_time
and all timestamps in schema/webhook/comment/etc. models to usedatetime.datetime
instead of thestr
representation that comes back from the API.The approach is a bit wonky – inspect pydantic field metadata, check types against fields and input, selectively convert data – but it works, and doesn't require us to do anything special per field except declare its type differently than what Airtable will hand back in the API.
This is certainly a breaking change, so I'd include it in a 3.0 release.