-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filtering feature that allows for swiping in mobile #19
Comments
I ... really love this idea. I'd been struggling with the idea of how to incorporate bookmarks into the app without overloading the filtering UI. Like, I keep seeing recipes that I want to try but don't feel like I'm ready to comment or favorite them. So if I could have lists of recipes (drinks for a party, favorites, drinks I want to try, drinks my Mom loves, etc.) then it'd be a great way of keeping arbitrary sets of recipes for whatever purpose. Though now I'm basically building Pinterest for lushes. |
So...basically laying the groundwork for an insanely successful product? |
Yeah, though it'll be a lot of work to even figure out how the UX is going to look. There appear to be some solid frameworks for mobile gestures, so that could be a starting point. |
Also, how should the desktop version work for actions that are swipe in mobile? an X? Arrows pointing left and right? |
I haven't really thought it through yet, but my rough thinking was that for list curation on desktops, you'd have the left-panel view to choose from and could drag recipes into the list a la Trello. Not sure yet how you'd remove them from the left panel (the swipe-left action on mobile). Plus desktop screens that are narrow should still support an add/remove capability without the side-by-side view. My head's getting a little fuzzy thinking about it. |
Well no need to feel fuzzy, you could also research options and it can wait until we can do a proper design session. |
Well, I'm thinking through data models, since that's a lot easier than the UI parts. I'm thinking something like:
Then maybe a But yes, I definitely want to do a real design session before trying to actually build anything involved. |
@jelloeggy - So I might have stayed up last night working on "swipe" gestures on the recipe list view. I have an experimental branch deployed temporarily if you want to give it a try on mobile. It's definitely not perfect, but I'm curious about what you think. |
Wow the swipe action is awesome (though hopefully you didn't lose sleep).
It's pretty slick. I assume it is just a "remove from this view" result at
the moment and doesn't actually add to a list somewhere depending on
left/right?
…On Mon, Mar 18, 2019, 07:42 Greg Thole ***@***.***> wrote:
@jelloeggy <https://github.com/jelloeggy> - So I might have stayed up
last night working on "swipe" gestures on the recipe list view. I have an
experimental branch deployed temporarily if you want to give it a try on
mobile. It's definitely not perfect, but I'm curious about what you think.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Aq7rTQlDOM-FVWk47sXh26C6k-J0B405ks5vX3u3gaJpZM4b3eeW>
.
|
Glad it works, and I didn't even lose any sleep over it! Correct - right now it doesn't do anything besides clear a recipe out of the list. My thinking is to next add Lists and an "Add to List" button on the recipe details page (which will replace favorites). I'll implement the rest of "swipe left to ignore" but remove "swipe right" for now, since I think that'll be a more complicated user experience to design. Do you have any thoughts on lists before I start working into it? |
Are you thinking that people would create and name their own lists? If so,
I think that sounds great, assuming you can add drinks to more than one
list. And then sharing/swipe to add/etc can come later.
…On Mon, Mar 18, 2019, 21:07 Greg Thole ***@***.***> wrote:
Glad it works, and I didn't even lose any sleep over it! Correct - right
now it doesn't do anything besides clear a recipe out of the list.
My thinking is to next add Lists and an "Add to List" button on the recipe
details page (which will replace favorites). I'll implement the rest of
"swipe left to ignore" but remove "swipe right" for now, since I think
that'll be a more complicated user experience to design.
Do you have any thoughts on lists before I start working into it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Aq7rTUMXCtkkhRluJ_D03GuQLo9J_Ju4ks5vYDhegaJpZM4b3eeW>
.
|
Yup - you got it! Users can each have multiple lists that have a name and description, and each recipe in the list can optionally have a note. |
OK, I have an early version of user lists working. It's not hooked up to the swipe gestures yet, so you add/remove recipes from lists on the recipe details view. There's a lot of cleanup work to do on it (make it prettier, etc), but I'd appreciate a product/QA round when you have the time. |
Product/QA round 1:
|
All good feedback. I'll take a look at incorporating some of these suggestions this week. My plan is to add list additions to the Activity Feed and comments the way that Favorites were, and eventually to add a way to filter the recipe list view by a user list like "Favorites", but that search/filter is what I'll need some help on, especially for swipe gesture managing lists. Keep the review ideas coming! |
Just playing with it on mobile (totally legitimate work time) and:
1) I just noticed the "notes" you can add to each recipe when you make a
list. Is that mobile only? What's the intended workflow?
2) It would be great to be able to do an initial search (i.e. NOT lime
juice, mezcal), swipe to clear out the list and then save the remaining
recipes as a list (although I suppose a quick "swipe right to list" feature
may capture this).
3) It also would be really helpful to have a total at the top of the recipe
filter that tells you how many recipes were returned. Given how many
recipes we have now it would be good to know how much more filtering you
need to do to get to a usable list, and it's not immediately apparent after
your initial search.
…On Mon, Mar 25, 2019 at 9:15 AM Greg Thole ***@***.***> wrote:
All good feedback. I'll take a look at incorporating some of these
suggestions this week. My plan is to add list additions to the Activity
Feed and comments the way that Favorites were, and eventually to add a way
to filter the recipe list view by a user list like "Favorites", but that
search/filter is what I'll need some help on, especially for swipe gesture
managing lists.
Keep the review ideas coming!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Aq7rTUTU0w544mJFbpgUsLrXZqFwgQQUks5vaMvugaJpZM4b3eeW>
.
|
For the rest of these, and the ones above, would you mind opening separate issues for them? I think it'd be easier for me to track and ask for feedback on individual changes that way. (Totally legitimate work time.) |
Ah, I see the notes on desktop now, they just seemed very prominent on mobile (smaller area to fill I suppose). Do the notes only exist in the context of that particular list? I like the idea of being able to make personal notes, but want to understand the context. Also, noted and accepted about splitting out my myriad thoughts into actual, distinct items. I will do so later tonight; prepare for the grace-git-onslaught (jelloeggy jamboree? hmm). |
The notes only exist in the context of that particular list. They won't show up anywhere else. (A "jameggy jellobee"? I may have lost the meaning, but it's fun to say out loud.) |
I love the idea of additional notes so let's leave it as is for now, I'll put another issue/suggestion if I have ideas as I play with it. Do you want to close this one out now? I've added "List creation options" as a separate item (#29) so that could capture the "swipe to add to list" request. Up to you, I'm sure there is satisfaction in closing these out. (Oh my goodness there totally needs to be a "jameggy jellobee" drink now. And/or a gif of dancing jelloeggs. I can work on one of those.) |
Yeah, I think this one has run its course. Thanks for all the review! (Even though I'm tempted to leave it open until there's either a "jameggy jellobee" drink or a dancing jelloegg gif.) |
Well there is a way to deal with that: #31 |
We should start to think about how people filter down to the drink they want to make, and potentially, to save drinks for later. Our new user suggested swiping, his notes on this topic:
I really like this as a mobile app, so yeah, anything that can utilize those gestures would be super helpful. For instance, if I search for something on Kindred Cocktails (on desktop) and get 30 recipes back, I will generally open them all in new tabs, then go through and close the tabs I decide against, leaving me with a shorter list I can whittle down. The swiping here would make that super easy -- filter down to a dozen recipes and then swipe away half of them quickly because they contain ingredients I don't like or don't have. You could even build on that gesture later on to swipe left for adding recipes to your own lists (e.g., create a new drinks list like "party drinks" for an upcoming event, then do a recipe search and filter down results, swiping ones you like into your list. Now you have a defined menu you can pull up any time at the party.)
The text was updated successfully, but these errors were encountered: