Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering feature that allows for swiping in mobile #19

Closed
jelloeggy opened this issue Mar 15, 2019 · 22 comments
Closed

Add filtering feature that allows for swiping in mobile #19

jelloeggy opened this issue Mar 15, 2019 · 22 comments
Labels
enhancement New feature or request ux suggestion Recommended change to User Experience

Comments

@jelloeggy
Copy link
Collaborator

We should start to think about how people filter down to the drink they want to make, and potentially, to save drinks for later. Our new user suggested swiping, his notes on this topic:

I really like this as a mobile app, so yeah, anything that can utilize those gestures would be super helpful. For instance, if I search for something on Kindred Cocktails (on desktop) and get 30 recipes back, I will generally open them all in new tabs, then go through and close the tabs I decide against, leaving me with a shorter list I can whittle down. The swiping here would make that super easy -- filter down to a dozen recipes and then swipe away half of them quickly because they contain ingredients I don't like or don't have. You could even build on that gesture later on to swipe left for adding recipes to your own lists (e.g., create a new drinks list like "party drinks" for an upcoming event, then do a recipe search and filter down results, swiping ones you like into your list. Now you have a defined menu you can pull up any time at the party.)

@jelloeggy jelloeggy added enhancement New feature or request ux suggestion Recommended change to User Experience labels Mar 15, 2019
@gthole
Copy link
Owner

gthole commented Mar 16, 2019

I ... really love this idea. I'd been struggling with the idea of how to incorporate bookmarks into the app without overloading the filtering UI. Like, I keep seeing recipes that I want to try but don't feel like I'm ready to comment or favorite them.

So if I could have lists of recipes (drinks for a party, favorites, drinks I want to try, drinks my Mom loves, etc.) then it'd be a great way of keeping arbitrary sets of recipes for whatever purpose.

Though now I'm basically building Pinterest for lushes.

@jelloeggy
Copy link
Collaborator Author

So...basically laying the groundwork for an insanely successful product?

@gthole
Copy link
Owner

gthole commented Mar 16, 2019

Yeah, though it'll be a lot of work to even figure out how the UX is going to look. There appear to be some solid frameworks for mobile gestures, so that could be a starting point.

@jelloeggy
Copy link
Collaborator Author

Also, how should the desktop version work for actions that are swipe in mobile? an X? Arrows pointing left and right?

@gthole
Copy link
Owner

gthole commented Mar 16, 2019

I haven't really thought it through yet, but my rough thinking was that for list curation on desktops, you'd have the left-panel view to choose from and could drag recipes into the list a la Trello. Not sure yet how you'd remove them from the left panel (the swipe-left action on mobile). Plus desktop screens that are narrow should still support an add/remove capability without the side-by-side view.

My head's getting a little fuzzy thinking about it.

@jelloeggy
Copy link
Collaborator Author

Well no need to feel fuzzy, you could also research options and it can wait until we can do a proper design session.

@gthole
Copy link
Owner

gthole commented Mar 16, 2019

Well, I'm thinking through data models, since that's a lot easier than the UI parts.

I'm thinking something like:

RecipeList
user_id -> User
name -> varchar
description -> varchar
created -> datetime
RecipeListEntry
list_id -> RecipeList
recipe_id -> Recipe
order -> number
notes -> varchar

Then maybe a Share object to let users share lists with each other.
I might also try implementing the "swipe left to dismiss" thing from the regular recipe view.

But yes, I definitely want to do a real design session before trying to actually build anything involved.

@gthole
Copy link
Owner

gthole commented Mar 18, 2019

@jelloeggy - So I might have stayed up last night working on "swipe" gestures on the recipe list view. I have an experimental branch deployed temporarily if you want to give it a try on mobile. It's definitely not perfect, but I'm curious about what you think.

@jelloeggy
Copy link
Collaborator Author

jelloeggy commented Mar 18, 2019 via email

@gthole
Copy link
Owner

gthole commented Mar 19, 2019

Glad it works, and I didn't even lose any sleep over it! Correct - right now it doesn't do anything besides clear a recipe out of the list.

My thinking is to next add Lists and an "Add to List" button on the recipe details page (which will replace favorites). I'll implement the rest of "swipe left to ignore" but remove "swipe right" for now, since I think that'll be a more complicated user experience to design.

Do you have any thoughts on lists before I start working into it?

@jelloeggy
Copy link
Collaborator Author

jelloeggy commented Mar 19, 2019 via email

@gthole
Copy link
Owner

gthole commented Mar 19, 2019

Yup - you got it! Users can each have multiple lists that have a name and description, and each recipe in the list can optionally have a note.

@gthole
Copy link
Owner

gthole commented Mar 25, 2019

OK, I have an early version of user lists working. It's not hooked up to the swipe gestures yet, so you add/remove recipes from lists on the recipe details view.

There's a lot of cleanup work to do on it (make it prettier, etc), but I'd appreciate a product/QA round when you have the time.

@jelloeggy
Copy link
Collaborator Author

Product/QA round 1:
So far, with very limited testing, I haven't found functional issues, but definitely some usability improvements to request.

  1. It's difficult to know that the drink has been added to the list. I think that maybe a check box when selecting the list might be clearer than highlighting? This is low priority. Also low priority, a clearer way to exit the "add to a list" workflow than "click on the x" (such as "Save", "Done", etc).
  2. More helpful would be a marker on the recipe itself indicating its now on a list, preferably even to see a summary of lists it's part of. Also, it was nice to see drinks that had been favorited by myself or others right from the recipe page and use it as a filter, perhaps the "Favorites" list could be a special list that has similar features. (OK pipe dream, but eventually users could choose an icon to associate with a list and then that icon would show up in the recipe choice view...spitballing here).
  3. The lists themselves are quite hidden. I did find them (in the profile) but ideally lists would be linked from several places (the main page, the recipe section).

@gthole
Copy link
Owner

gthole commented Mar 25, 2019

All good feedback. I'll take a look at incorporating some of these suggestions this week. My plan is to add list additions to the Activity Feed and comments the way that Favorites were, and eventually to add a way to filter the recipe list view by a user list like "Favorites", but that search/filter is what I'll need some help on, especially for swipe gesture managing lists.

Keep the review ideas coming!

@jelloeggy
Copy link
Collaborator Author

jelloeggy commented Mar 25, 2019 via email

@gthole
Copy link
Owner

gthole commented Mar 25, 2019

  1. Notes are on desktop view too (or at least they should be). The idea is that you might want to jot down some thoughts about a recipe in the context of that list - my use case is that I want to track things that I've made for people and whether they liked it or not, also what variations I might have made for that person that I wouldn't do otherwise. Does it seem worthwhile to you?

For the rest of these, and the ones above, would you mind opening separate issues for them? I think it'd be easier for me to track and ask for feedback on individual changes that way.

(Totally legitimate work time.)

@jelloeggy
Copy link
Collaborator Author

Ah, I see the notes on desktop now, they just seemed very prominent on mobile (smaller area to fill I suppose). Do the notes only exist in the context of that particular list? I like the idea of being able to make personal notes, but want to understand the context.

Also, noted and accepted about splitting out my myriad thoughts into actual, distinct items. I will do so later tonight; prepare for the grace-git-onslaught (jelloeggy jamboree? hmm).

@gthole
Copy link
Owner

gthole commented Mar 25, 2019

The notes only exist in the context of that particular list. They won't show up anywhere else.

(A "jameggy jellobee"? I may have lost the meaning, but it's fun to say out loud.)

@jelloeggy
Copy link
Collaborator Author

jelloeggy commented Mar 26, 2019

I love the idea of additional notes so let's leave it as is for now, I'll put another issue/suggestion if I have ideas as I play with it.

Do you want to close this one out now? I've added "List creation options" as a separate item (#29) so that could capture the "swipe to add to list" request. Up to you, I'm sure there is satisfaction in closing these out.

(Oh my goodness there totally needs to be a "jameggy jellobee" drink now. And/or a gif of dancing jelloeggs. I can work on one of those.)

@gthole
Copy link
Owner

gthole commented Mar 26, 2019

Yeah, I think this one has run its course. Thanks for all the review! (Even though I'm tempted to leave it open until there's either a "jameggy jellobee" drink or a dancing jelloegg gif.)

@gthole gthole closed this as completed Mar 26, 2019
@jelloeggy
Copy link
Collaborator Author

Well there is a way to deal with that: #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux suggestion Recommended change to User Experience
Projects
None yet
Development

No branches or pull requests

2 participants