Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit ol-ext version to 4.0.18 and update yarn.lock #331

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

sanak
Copy link
Member

@sanak sanak commented Aug 9, 2024

Fixes the following error.
https://github.com/sanak/redmine_gtt/actions/runs/10280544083/job/28448110645#step:8:53

ERROR in ./node_modules/ol-ext/interaction/Hover.js 2:0-45
Module not found: Error: Can't resolve '../util/element' in '/__w/redmine_gtt/redmine_gtt/redmine/plugins/redmine_gtt/node_modules/ol-ext/interaction'
Did you mean 'element.js'?
BREAKING CHANGE: The request '../util/element' failed to resolve only because it was resolved as fully specified

Changes proposed in this pull request:

@dkastl
I think that you are waiting for ol-ext next release (4.0.22) which includes your PR, but now CI is failing (like on my fork action), so this PR is just limit ol-ext version to 4.0.18 like your PR:#330.
Could you check this when you have a time ?

After this PR is approved and merged, I will create PR for deface override fix.

@sanak sanak added the bug Something isn't working label Aug 9, 2024
@sanak sanak self-assigned this Aug 9, 2024
@sanak sanak requested a review from dkastl August 9, 2024 01:23
Copy link
Member

@dkastl dkastl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I've been waiting for a new release, because they usually come quickly ... except this time, it seems. So this PR is a good idea.

@dkastl dkastl merged commit 8bca6e2 into next Aug 9, 2024
10 checks passed
@dkastl dkastl deleted the fix/limit-ol-ext-version branch August 9, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants