Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace removed jQuery api '.size()' to '.length' #25

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

sanak
Copy link
Member

@sanak sanak commented Aug 23, 2024

Fixes removed deprecated jQuery API (.size()) error after Redmine 5.0.

Changes proposed in this pull request:

  • Replace removed jQuery API '.size()to.length`.

@mopinfish (CC: @dkastl)
Target branch is main, because next branch includes upcoming disabling supply/resource item deletion.
And I will create similar PRs to Privacy and TextBlocks plugins.

@sanak sanak added the bug Something isn't working label Aug 23, 2024
@sanak sanak requested review from dkastl and mopinfish August 23, 2024 04:09
@sanak sanak self-assigned this Aug 23, 2024
Copy link

@mopinfish mopinfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanak
Copy link
Member Author

sanak commented Aug 23, 2024

Thanks!
I will merge this.
About CI test error, I will create another PR for that.

@sanak sanak merged commit 129bec0 into main Aug 23, 2024
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants