Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ApplicationLoggingProps to GuAutoScalingGroup #1800

Open
akash1810 opened this issue Mar 31, 2023 · 0 comments
Open

Add ApplicationLoggingProps to GuAutoScalingGroup #1800

akash1810 opened this issue Mar 31, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@akash1810
Copy link
Member

akash1810 commented Mar 31, 2023 •
edited
Loading

If one adds the cdk-base role to their AMIgo recipe, they are then able to ship their journald logs to ELK via fluentbit, but only if they use the GuEC2App pattern. This is achieved via the ApplicationLoggingProps.

It should be possible to set these application logging props at the GuAutoScalingGroup level too, for those applications that do not use the pattern, as they do not require a load balancer.

See https://github.com/guardian/service-catalogue/pull/157/files.
@akash1810 akash1810 added the good first issue Good for newcomers label Mar 31, 2023
@akash1810 akash1810 changed the title Add devx-logs tagging requirements to GuAutoScalingGroup Add devx-logs tagging requirements to GuAutoScalingGroup Mar 31, 2023
@akash1810 akash1810 changed the title Add devx-logs tagging requirements to GuAutoScalingGroup Add ApplicationLoggingProps to GuAutoScalingGroup Mar 31, 2023
akash1810 added a commit to guardian/service-catalogue that referenced this issue Mar 31, 2023
@akash1810 @tjsilver
@NovemberTang @nicl @JuliaBrigitte
fix(cloudquery): Add required ASG tags for devx-logs
7a3f29e 
The `LogKinesisStreamName` and `SystemdUnit` tags are required by `devx-logs`.

GuCDK only adds these tags automatically at the pattern level, so we have manually add them.

See guardian/cdk#1800.

Co-authored-by: TJ Silver <tjsilver@users.noreply.github.com>
Co-authored-by: NovemberTang <novembertang@users.noreply.github.com>
Co-authored-by: nicl <nicl@users.noreply.github.com>
Co-authored-by: JuliaBrigitte <JuliaBrigitte@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akash1810