-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(experimental-ec2-pattern): Pattern to deploy ASG updates w/CFN #2417
Commits on Sep 17, 2024
-
fix(riff-raff.yaml): Do not deploy ASG w/update policy
ASGs with an update policy will get deployed via CloudFormation, instead of Riff-Raff's `autoscaling` deployment type.
Configuration menu - View commit details
-
Copy full SHA for 0ccfcef - Browse repository at this point
Copy the full SHA 0ccfcefView commit details -
feat(experimental-ec2-pattern): Add pattern to deploy ASGs updates vi…
…a CloudFormation (`AutoScalingRollingUpdate`)
Configuration menu - View commit details
-
Copy full SHA for 24df0b2 - Browse repository at this point
Copy the full SHA 24df0b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10701fd - Browse repository at this point
Copy the full SHA 10701fdView commit details -
feat(experimental-ec2-pattern): Decorate added user data commands w/m…
…arkers This should make it easier to parse a user data string if ever one is debugging.
Configuration menu - View commit details
-
Copy full SHA for c83449c - Browse repository at this point
Copy the full SHA c83449cView commit details -
Configuration menu - View commit details
-
Copy full SHA for de842f6 - Browse repository at this point
Copy the full SHA de842f6View commit details -
fix(experimental-ec2-pattern): Set ASG
DesiredCapacity
During a deployment, CloudFormation updates the min and desired. During a rollback (e.g. if the healthcheck failed), CloudFormation only resets the min. The desired is still elevated, meaning the service is over provisioned. Explicitly setting the desired property of the ASG ensures CloudFormation rollback puts the ASG back to the initial state, e.g. correctly provisioned.
Configuration menu - View commit details
-
Copy full SHA for 3fe10c6 - Browse repository at this point
Copy the full SHA 3fe10c6View commit details -
refactor(experimental-ec2-pattern): Use the same duration when creati…
…ng and updating ASG
Configuration menu - View commit details
-
Copy full SHA for 6efd2dc - Browse repository at this point
Copy the full SHA 6efd2dcView commit details -
fix(experimental-ec2-pattern): Suspend alarm notifications
A scale-in event fires during a rolling update can cause service disruption. Suspend scaling events during a rolling update for safety.
Configuration menu - View commit details
-
Copy full SHA for e089a84 - Browse repository at this point
Copy the full SHA e089a84View commit details -
feat(experimental-ec2-pattern): Adjust ASG rolling update properties …
…where scaling policy present Some practical testing of `AutoScalingRollingUpdate` has demonstrated that when an ASG has a scaling policy, it is safest to dynamically set the `MinInstancesInService` property. Add an aspect to do that. See also https://github.com/guardian/testing-asg-rolling-update.
Configuration menu - View commit details
-
Copy full SHA for b2d7782 - Browse repository at this point
Copy the full SHA b2d7782View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22c9e48 - Browse repository at this point
Copy the full SHA 22c9e48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ce18cd - Browse repository at this point
Copy the full SHA 5ce18cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for ddb3a1e - Browse repository at this point
Copy the full SHA ddb3a1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 767ec0f - Browse repository at this point
Copy the full SHA 767ec0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8f6ff5 - Browse repository at this point
Copy the full SHA b8f6ff5View commit details -
fix(experimental-ec2-pattern): Obtain instance id more reliably
The `ec2metadata` command was failing with a 401 with AMIable CODE in deployTools account: ```console root@ip-10-248-51-213:/var/lib/cloud/instance# ec2metadata --instance-id Traceback (most recent call last): File "/usr/bin/ec2metadata", line 249, in <module> main() File "/usr/bin/ec2metadata", line 245, in main display(metaopts, burl, prefix) File "/usr/bin/ec2metadata", line 192, in display value = m.get(metaopt) File "/usr/bin/ec2metadata", line 177, in get return self._get('meta-data/' + metaopt) File "/usr/bin/ec2metadata", line 137, in _get resp = urllib_request.urlopen(urllib_request.Request(url)) File "/usr/lib/python3.8/urllib/request.py", line 222, in urlopen return opener.open(url, data, timeout) File "/usr/lib/python3.8/urllib/request.py", line 531, in open response = meth(req, response) File "/usr/lib/python3.8/urllib/request.py", line 640, in http_response response = self.parent.error( File "/usr/lib/python3.8/urllib/request.py", line 569, in error return self._call_chain(*args) File "/usr/lib/python3.8/urllib/request.py", line 502, in _call_chain result = func(*args) File "/usr/lib/python3.8/urllib/request.py", line 649, in http_error_default raise HTTPError(req.full_url, code, msg, hdrs, fp) urllib.error.HTTPError: HTTP Error 401: Unautho ``` This service uses IMDSv2. A 401 response usually happens when a request is made without a token. However `ec2metadata` does exchange a token. Switch to a more reliable mechanism. See https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html.
Configuration menu - View commit details
-
Copy full SHA for b0718b4 - Browse repository at this point
Copy the full SHA b0718b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4e2a7c - Browse repository at this point
Copy the full SHA f4e2a7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98f8f9f - Browse repository at this point
Copy the full SHA 98f8f9fView commit details -
refactor(experimental-ec2-pattern): Remove duplicated test
The behaviour being tested is already covered by `should only adjust properties of a horizontally scaling service`.
Configuration menu - View commit details
-
Copy full SHA for 37c9533 - Browse repository at this point
Copy the full SHA 37c9533View commit details -
Configuration menu - View commit details
-
Copy full SHA for a259531 - Browse repository at this point
Copy the full SHA a259531View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b330b6 - Browse repository at this point
Copy the full SHA 7b330b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ebd343 - Browse repository at this point
Copy the full SHA 3ebd343View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d96a1a - Browse repository at this point
Copy the full SHA 4d96a1aView commit details -
fix(experimental-ec2-pattern): Set
PauseTime
from healthcheck grace…… period Matching these properties allows rollbacks to happen as quickly as possible.
Configuration menu - View commit details
-
Copy full SHA for 7a12f60 - Browse repository at this point
Copy the full SHA 7a12f60View commit details