Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabric Web migration to Svelte #339

Merged
merged 25 commits into from
Jan 29, 2024
Merged

Fabric Web migration to Svelte #339

merged 25 commits into from
Jan 29, 2024

Commits on Jan 25, 2024

  1. Start migrating fabric template 

    Co-authored-by: Dominik Lander <dominik.lander@guardian.co.uk>
Co-authored-by: Dina Hafez <dina.hafez@guardian.co.uk>
Co-authored-by: Emma Imber <108270776+emma-imber@users.noreply.github.com>
Co-authored-by: Demetrios Skamiotis <demetrios.skamiotis@guardian.co.uk>
    @domlander @deedeeh
    @emma-imber @dskamiotis
    4 people committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    fb928e3 View commit details
    Browse the repository at this point in the history

  2. Add AdvertisementLabel component and test.json

    @deedeeh @domlander
    deedeeh authored and domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    1493c7b View commit details
    Browse the repository at this point in the history

  3. Add Pixel component and fabric index.svelte

    @deedeeh @domlander
    deedeeh authored and domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    dba7608 View commit details
    Browse the repository at this point in the history

  4. Add export to index.ts to pass CI

    @deedeeh @domlander
    deedeeh authored and domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    b69da95 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary files from this PR but adding the old func name

    @deedeeh @domlander
    deedeeh authored and domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    5aa41c7 View commit details
    Browse the repository at this point in the history

  6. Remove the unused key/value in test.json

    @deedeeh @domlander
    deedeeh authored and domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    2399969 View commit details
    Browse the repository at this point in the history

  7. Addressed review comments

    @deedeeh @domlander
    deedeeh authored and domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    f088aa0 View commit details
    Browse the repository at this point in the history

  8. Refactored with css variables to reduce code

    @deedeeh @domlander
    deedeeh authored and domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    bcfbccd View commit details
    Browse the repository at this point in the history

  9. Add a 100% width preview

    @Jakeii @domlander
    Jakeii authored and domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    d93467a View commit details
    Browse the repository at this point in the history

  10. Refactor gs-container in its own file

    @deedeeh @domlander
    deedeeh authored and domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    86a06a5 View commit details
    Browse the repository at this point in the history

  11. Add margin to gs-container and remove redundant code

    @deedeeh @domlander
    deedeeh authored and domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    7ffaf74 View commit details
    Browse the repository at this point in the history

  12. Update src/templates/ssr/fabric/index.svelte 

    Co-authored-by: Jake Lee Kennedy <jake.kennedy@guardian.co.uk>
    @deedeeh @Jakeii @domlander
    2 people authored and domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    ee2b06e View commit details
    Browse the repository at this point in the history

  13. Fix lint error

    @deedeeh @domlander
    deedeeh authored and domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    6e04cef View commit details
    Browse the repository at this point in the history

  14. Replace media queries inside creative--fabric for specificity

    @deedeeh @domlander
    deedeeh authored and domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    bc27ba5 View commit details
    Browse the repository at this point in the history

  15. Relocate fabric web to csr for parallax functionality

    @deedeeh @domlander
    deedeeh authored and domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    cd3cc48 View commit details
    Browse the repository at this point in the history

  16. Add ad.json with the fabric-web native style id

    @deedeeh @domlander
    deedeeh authored and domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    25cd3c9 View commit details
    Browse the repository at this point in the history

  17. Add css rule background size cover for non parallax ads

    @deedeeh @domlander
    deedeeh authored and domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    db57c7c View commit details
    Browse the repository at this point in the history

  18. Start migrating fabric template 

    Co-authored-by: Dominik Lander <dominik.lander@guardian.co.uk>
Co-authored-by: Dina Hafez <dina.hafez@guardian.co.uk>
Co-authored-by: Emma Imber <108270776+emma-imber@users.noreply.github.com>
Co-authored-by: Demetrios Skamiotis <demetrios.skamiotis@guardian.co.uk>
    @domlander @deedeeh
    @emma-imber @dskamiotis
    4 people committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    c7220c3 View commit details
    Browse the repository at this point in the history

  19. Add AdvertisementLabel component and test.json

    @deedeeh @domlander
    deedeeh authored and domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    60ce79e View commit details
    Browse the repository at this point in the history

  20. Remove unnecessary files from this PR but adding the old func name

    @deedeeh @domlander
    deedeeh authored and domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    571bbb0 View commit details
    Browse the repository at this point in the history

  21. Update advertisement label not to use pallette (will be reinstated in… 

    … follow-up PR)

Co-authored-by: Jake Lee Kennedy <jlkennedy127@gmail.com>
    @domlander @Jakeii
    domlander and Jakeii committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    f3da325 View commit details
    Browse the repository at this point in the history

  22. Use simpler class names. Remove helpers file. 

    Co-authored-by: Jake Lee Kennedy <jlkennedy127@gmail.com>
    @domlander @Jakeii
    domlander and Jakeii committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    0b11f10 View commit details
    Browse the repository at this point in the history

  23. delete superfluous files 

    Co-authored-by: Jake Lee Kennedy <jlkennedy127@gmail.com>
    @domlander @Jakeii
    domlander and Jakeii committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    91486d0 View commit details
    Browse the repository at this point in the history

  24. fix ad label positioning. Remove unneeded media queries

    @domlander
    domlander committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    d7e616e View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Correct width of ad and ad label

    @domlander
    domlander committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    833aff9 View commit details
    Browse the repository at this point in the history