Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPI Multiple PaidFor fixes #352

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Conversation

emma-imber
Copy link
Contributor

What does this change?

A number of small fixes for the CAPI Multiple PaidFor template:

  • Adds target="_top" to the CapiCard link to ensure that articles open up in the full window and not just the ad iframe (see figure 1)
  • Adds a margin: 0 to the body so that ads on Firefox display as expected (on Firefox the default margin is not 0, see figure 2)
  • Resizes the headers to line up with the lines on the webpage, as the width did not take into account the 40px padding (see figure 3)
  • Also set the test.json to an active campaign to help with testing

Figure 1

The link should open in the main window, not the iframe

Screenshot 2024-01-10 at 14 38 58

Figure 2

The ad shouldn't have any extra margin around it (Firefox specific issue)

Screenshot 2024-01-10 at 17 44 46

Figure 3

The right side of the header should line up with the line above it

Screenshot 2024-01-10 at 18 09 01

Copy link
Member

@Jakeii Jakeii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@emma-imber emma-imber merged commit 7248871 into main Jan 11, 2024
4 checks passed
@emma-imber emma-imber deleted the ei/capi-multiple-styling-fixes branch January 11, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants